-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(create-prs-to-update-vcs-repositories): new github action #317
feat(create-prs-to-update-vcs-repositories): new github action #317
Conversation
Signed-off-by: Junya Sasaki <junya.sasaki@tier4.jp>
…-vcs-repositories-update Signed-off-by: Junya Sasaki <junya.sasaki@tier4.jp>
…in README.md Signed-off-by: Junya Sasaki <junya.sasaki@tier4.jp>
Signed-off-by: Junya Sasaki <junya.sasaki@tier4.jp>
… property Signed-off-by: Junya Sasaki <junya.sasaki@tier4.jp>
…-slash Signed-off-by: Junya Sasaki <junya.sasaki@tier4.jp>
…in README.md Signed-off-by: Junya Sasaki <junya.sasaki@tier4.jp>
Signed-off-by: Junya Sasaki <junya.sasaki@tier4.jp>
Signed-off-by: Junya Sasaki <junya.sasaki@tier4.jp>
…ies' of https://github.com/sasakisasaki/autoware-github-actions into add-feature-for-creating-prs-which-update-vcs-repositories Signed-off-by: Junya Sasaki <junya.sasaki@tier4.jp>
…due to a word "Github" Signed-off-by: Junya Sasaki <junya.sasaki@tier4.jp>
* noqa does not work for cspell check Signed-off-by: Junya Sasaki <junya.sasaki@tier4.jp>
What about renaming the workflow?
|
create-prs-for-vcs-repositories-update/create_prs_for_vcs_repositories_update.py
Outdated
Show resolved
Hide resolved
create-prs-for-vcs-repositories-update/create_prs_for_vcs_repositories_update.py
Outdated
Show resolved
Hide resolved
create-prs-for-vcs-repositories-update/create_prs_for_vcs_repositories_update.py
Outdated
Show resolved
Hide resolved
Signed-off-by: Junya Sasaki <junya.sasaki@tier4.jp>
…t folder * create-prs-for-vcs-repositories-update -> create-prs-to-update-vcs-repositories Signed-off-by: Junya Sasaki <junya.sasaki@tier4.jp>
* create-prs-for-vcs-repositories-update -> create-prs-to-update-vcs-repositories Signed-off-by: Junya Sasaki <junya.sasaki@tier4.jp>
…ontext aware Signed-off-by: Junya Sasaki <junya.sasaki@tier4.jp>
…side of used scope Signed-off-by: Junya Sasaki <junya.sasaki@tier4.jp>
… scope Signed-off-by: Junya Sasaki <junya.sasaki@tier4.jp>
Signed-off-by: Junya Sasaki <junya.sasaki@tier4.jp>
@xmfcx Thank you so much for your review!
Good to me! Renamed 👍 . |
@Shin-kyoto Thank you so much for your review! Now I applied the suggestions 👍 . |
I fixed an issue in the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!! LGTM.
Description
Add a workflow that creates PRs if the expected format tag is attached for vcs imported repositories.
Related links
Semantic Versioning Discussion
Tests performed (Referenced from the URL in "Related links")
Premise
semantic_version_pattern = r'\b(v?\d+\.\d+(?:\.\d+)?(?:-\w+)?(?:\+\w+(\.\d+)?)?)\b'
Test Cases
The following tests passed:
Duplicate PR Prevention
Multiple Repository Updates
Idempotent Behavior
Post-Merge Behavior
Notes for reviewers
Perhaps some effective tests are missing in the list of tests above. I'm welcome doing the proposed tests. Your feedback is highly appreciated.
Interface changes
No change exists in this my PR
Effects on system behavior
Once this workflow is introduced into the autoware repository, new PRs related to versioning will be created automatically.
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.