Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: rework mutexes #10

Merged
merged 1 commit into from
Mar 5, 2025

Conversation

amadeuszsz
Copy link
Collaborator

Description

This PR replaces the global mutex with more granular locks for specific class members, improving concurrency and scalability by allowing finer control over locking individual members instead of the entire class.

Tests performed

Not applicable.

Effects on system behavior

Not applicable.

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

Signed-off-by: Amadeusz Szymko <amadeusz.szymko.2@tier4.jp>
@amadeuszsz amadeuszsz added the enhancement New feature or request label Mar 5, 2025
@amadeuszsz amadeuszsz self-assigned this Mar 5, 2025
@amadeuszsz amadeuszsz merged commit 367d8f2 into autowarefoundation:main Mar 5, 2025
12 checks passed
Copy link

codecov bot commented Mar 5, 2025

Codecov Report

Attention: Patch coverage is 88.23529% with 2 lines in your changes missing coverage. Please review.

Project coverage is 79.27%. Comparing base (4d203ae) to head (da66dc3).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
...m_buffer/src/managed_transform_buffer_provider.cpp 86.66% 0 Missing and 2 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #10      +/-   ##
==========================================
+ Coverage   79.00%   79.27%   +0.27%     
==========================================
  Files           4        4              
  Lines         400      415      +15     
  Branches      191      204      +13     
==========================================
+ Hits          316      329      +13     
+ Misses         20       19       -1     
- Partials       64       67       +3     
Flag Coverage Δ *Carryforward flag
differential 79.22% <88.23%> (?)
total 78.89% <ø> (-0.11%) ⬇️ Carriedforward from 4d203ae

*This pull request uses carry forward flags. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Clang-Tidy found issue(s) with the introduced code (1/1)

@@ -206,7 +218,7 @@ std::optional<TransformStamped> ManagedTransformBufferProvider::lookupTransform(

TraverseResult ManagedTransformBufferProvider::traverseTree(
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ readability-function-cognitive-complexity ⚠️
function traverseTree has cognitive complexity of 34 (threshold 25)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant