Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid consider PATH updated when the export is commented in the shellrc #12043

Merged
merged 3 commits into from
Mar 8, 2025
+6 −1
Merged

Avoid consider PATH updated when the export is commented in the shellrc #12043

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
3db8f04
Avoid consider PATH updated when the export is commented in the shell
JonCholas Mar 7, 2025
0c15118
Merge branch 'main' into joncholas/improve-update-shell
charliermarsh Mar 8, 2025
d8e4acf
Skip comments
charliermarsh Mar 8, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion crates/uv/src/commands/tool/update_shell.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -73,7 +73,7 @@ pub(crate) async fn update_shell(printer: Printer) -> Result<ExitStatus> {
// Search for the command in the file, to avoid redundant updates.
match fs_err::tokio::read_to_string(&file).await {
Ok(contents) => {
if contents.contains(&command) {
if contents.lines().any(|line| line.trim() == command.trim()) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could we instead skip lines that start with #?

debug!(
"Skipping already-updated configuration file: {}",
file.simplified_display()
Expand Down
Loading