Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pjsip/rest_api: Introduce a test for ChannelTransfer event #77

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

zecke
Copy link

@zecke zecke commented Dec 9, 2024

Test that a SIP REFER is translated into a ChannelTransfer event when TRANSFERHANDLING=ari-only is set on the channel and that transfer_progress generates the necessary SIP NOTIFY messages.

Be strict on the first ChannelTransfer event being received. Then only check that the transfer state is changing from not being present, to progress and finally answered. When answered delete all the channels and the bridge and the test wull succeed.

@zecke
Copy link
Author

zecke commented Jan 24, 2025

Attempt to use the dialplan function over a "well-known" variable.

Copy link

REMINDER: If this PR applies to other branches, please add a comment with the appropriate "cherry-pick-to" headers as per the [Create a Pull Request](https://docs.asterisk.org/Development/Policies-and-Procedures/Code-Contribution) process.

If you don't want it cherry-picked, please add a "cherry-pick-to: none" comment so we don't keep asking.

If, after adding "cherry-pick-to" comments, you change your mind, please edit the comment to DELETE the header lines and add "cherry-pick-to: none".

The currently active branches are now 20, 21, 22 and master.

@zecke
Copy link
Author

zecke commented Feb 12, 2025

cherry-pick-to: 20
cherry-pick-to: 21
cherry-pick-to: 22

@github-actions github-actions bot added cherry-pick-testing-in-progress Cherry-Pick tests in progress cherry-pick-checks-failed Cherry-Pick checks failed and removed cherry-pick-test cherry-pick-testing-in-progress Cherry-Pick tests in progress labels Feb 12, 2025
@gtjoseph gtjoseph added cherry-pick-test and removed cherry-pick-checks-failed Cherry-Pick checks failed labels Feb 19, 2025
@github-actions github-actions bot added cherry-pick-testing-in-progress Cherry-Pick tests in progress cherry-pick-checks-failed Cherry-Pick checks failed and removed cherry-pick-test cherry-pick-testing-in-progress Cherry-Pick tests in progress labels Feb 19, 2025
Copy link

Workflow PRCPCheck failed
Setup: cherryPick.sh: Unable to cherry-pick commit 'Merge branch 'master' into zecke-ari-only' to branch 20
Setup: cherryPick.sh: Unable to cherry-pick commit 'Merge branch 'master' into zecke-ari-only' to branch 21
Setup: cherryPick.sh: Unable to cherry-pick commit 'Merge branch 'master' into zecke-ari-only' to branch 22

Copy link
Member

@gtjoseph gtjoseph left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@zecke You need to get rid of the merge commit in this PR.

Test that a SIP REFER is translated into a ChannelTransfer event when
TRANSFERHANDLING=ari-only is set on the channel and that
transfer_progress generates the necessary SIP NOTIFY messages.

Be strict on the first ChannelTransfer event being received. Then only
check that the transfer state is changing from not being present, to
progress and finally answered. When answered delete all the channels and
the bridge and the test wull succeed.
Copy link

github-actions bot commented Mar 1, 2025

Workflow PRCheck completed successfully

@zecke
Copy link
Author

zecke commented Mar 1, 2025

I am looking at https://github.com/asterisk/asterisk/actions/runs/13272885836/job/37056440524 which failed when asterisk/asterisk#1102 was merged. While I don't see a way to get the "asterisk" binary that was used to run the test, the full.txt has this as the output:

[Feb 11 21:41:33] Asterisk GIT-master-1f1fa06 built by runner @ fv-az2027-701 on a x86_64 running Linux on 2025-02-11 21:32:26 UTC

What is the probability that the "20-ari" test didn't use an Asterisk 20 binary with the patch to be cherry picked?

@zecke zecke requested a review from gtjoseph March 1, 2025 13:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants