-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(anta.tests): Cleaning up BFD tests module #926
Merged
Merged
+177
−148
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
32 tasks
8badc0e
to
277e506
Compare
CodSpeed Performance ReportMerging #926 will not alter performanceComparing Summary
|
277e506
to
7eac1ad
Compare
carl-baillargeon
approved these changes
Nov 22, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
gmuloc
reviewed
Nov 25, 2024
cfde1c2
to
fb5b383
Compare
gmuloc
approved these changes
Nov 26, 2024
|
geetanjalimanegslab
pushed a commit
to geetanjalimanegslab/anta
that referenced
this pull request
Dec 10, 2024
* Refactor: VerifyBFDPeersRegProtocols, VerifyBFDPeersIntervals, VerifyBFDSpecificPeers * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * Updated unit tests and docs * Addressed review commentsL: updated failure msgs * updated failure msgs: removed , and ; * updated docstring --------- Co-authored-by: VitthalMagadum <yvitthal.magadum-ext@arista.com> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Co-authored-by: Guillaume Mulocher <gmulocher@arista.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Refactoring BFD tests module to address the following issues:
Checklist:
pre-commit run
)tox -e testenv
)