feat(anta.tests): Add test for Maintenance mode #1067
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
emilarista
changed the title
gmuloc
reviewed
Mar 6, 2025
Comment on lines
+397
to
+398
| if not under and not entering and not causes: | ||
| self.result.is_success() |
There was a problem hiding this comment.
you already set is_success at the beginning so you don't need this. you can just return
anta/tests/system.py
Outdated
Comment on lines
402
to
409
| message = "" | ||
| if under: | ||
| message += f"Units under maintenance: '{unitsundermaintenance}'. " | ||
| if entering: | ||
| message += f"Units entering maintenance: '{unitsenteringmaintenance}'. " | ||
| if len(causes) > 0: | ||
| message += f"Possible causes: '{causes}'" | ||
| self.result.is_failure(message) |
There was a problem hiding this comment.
we have a list os messages so yuo can do instead:
Suggested change
| message = "" | |
| if under: | |
| message += f"Units under maintenance: '{unitsundermaintenance}'. " | |
| if entering: | |
| message += f"Units entering maintenance: '{unitsenteringmaintenance}'. " | |
| if len(causes) > 0: | |
| message += f"Possible causes: '{causes}'" | |
| self.result.is_failure(message) | |
| if units_under_maintenance: | |
| self.result.is_failure(f"Units under maintenance: '{', '.join(units_under_maintenance)}'.") | |
| if units_entering_maintenance: | |
| self.result.is_failure(f"Units entering maintenance: '{', '.join(units_entering_maintenance)}'.") | |
| if len(causes) > 0: | |
| self.result.is_failure(f"Possible causes: '{', '.join(causes}'") |
Comment on lines
+378
to
+379
| under = False | ||
| entering = False |
There was a problem hiding this comment.
you don't need the flags as you just need to check if the lists are empty or not
Comment on lines
+376
to
+377
| unitsundermaintenance = [] | ||
| unitsenteringmaintenance = [] |
There was a problem hiding this comment.
Suggested change
| unitsundermaintenance = [] | |
| unitsenteringmaintenance = [] | |
| units_under_maintenance = [] | |
| units_entering_maintenance = [] |
Comment on lines
+384
to
+385
| unitsundermaintenance.append(unit) | ||
| under = True |
There was a problem hiding this comment.
Suggested change
| unitsundermaintenance.append(unit) | |
| under = True | |
| units_under_maintenance.append(unit) |
Comment on lines
+387
to
+388
| unitsenteringmaintenance.append(unit) | ||
| entering = True |
There was a problem hiding this comment.
Suggested change
| unitsenteringmaintenance.append(unit) | |
| entering = True | |
| units_entering_maintenance.append(unit) |
anta/tests/system.py
Outdated
Comment on lines
390
to
394
| causes.append("quiesce is configured") | ||
| if info["onBootMaintenance"]: | ||
| causes.append("On-boot maintenance is configured") | ||
| if info["intfsViolatingTrafficThreshold"]: | ||
| causes.append("Interface traffic threshold violation") |
There was a problem hiding this comment.
Suggested change
| causes.append("quiesce is configured") | |
| if info["onBootMaintenance"]: | |
| causes.append("On-boot maintenance is configured") | |
| if info["intfsViolatingTrafficThreshold"]: | |
| causes.append("Interface traffic threshold violation") | |
| causes.append("quiesce is configured.") | |
| if info["onBootMaintenance"]: | |
| causes.append("On-boot maintenance is configured.") | |
| if info["intfsViolatingTrafficThreshold"]: | |
| causes.append("Interface traffic threshold violation.") |
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Test to verify if one or more units are under or entering maintenance mode for different reasons:
Checklist:
pre-commit run)tox -e testenv)