feat(anta): Added test case to verify isis interface authentication mode #1064
+855
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CodSpeed Performance ReportMerging #1064 will not alter performanceComparing Summary
|
|
vitthalmagadum
requested changes
Mar 6, 2025
| interfaces: list[ISISInterface] | None = None | ||
| """IS-IS interfaces detail. Required field in the `VerifyISISInterfaceAuthMode` test.""" | ||
|
|
||
| # TODO: Need to review this in ANTA 2.0 as VRF is used in both ISISInterface model. |
There was a problem hiding this comment.
Suggested change
| # TODO: Need to review this in ANTA 2.0 as VRF is used in both ISISInterface model. | |
| # TODO: Need to review this model in ANTA 2.0 as VRF is used in ISISInterface model as well. |
| @@ -64,6 +68,12 @@ class ISISInterface(BaseModel): | |||
| """Expected number of IS-IS neighbors on this interface. Required field in the `VerifyISISNeighborCount` test.""" | |||
| mode: Literal["point-to-point", "broadcast", "passive"] | None = None | |||
| """IS-IS network type of the interface. Required field in the `VerifyISISInterfaceMode` test.""" | |||
| authentication_mode: Literal["MD5", "Text", "SHA", "shared-secret"] | None = None | |||
| """IS-IS authentication mode. Required field in the `VerifyISISInterfaceAuthMode` test.""" | |||
| auth_key_id: int | None = None | |||
There was a problem hiding this comment.
This should be constrained.
| anta.tests.routing: | ||
| isis: | ||
| - VerifyISISInterfaceAuthMode: | ||
| instances: |
There was a problem hiding this comment.
It will not affect but please take care of indentation
| raise ValueError(msg) | ||
| return instances | ||
|
|
||
| def _validate_isis_auth_mode(self, instance_data: str, act_interface_detail: dict[str, Any], interface_data: dict[str, Any]) -> str | None: |
There was a problem hiding this comment.
Suggested change
| def _validate_isis_auth_mode(self, instance_data: str, act_interface_detail: dict[str, Any], interface_data: dict[str, Any]) -> str | None: | |
| def _validate_isis_auth_mode(self, instance_data: ISISInstance, interface_data: ISISInterface, act_interface_detail: dict[str, Any]) -> str | None: |
|
|
||
| # If authentication mode is not configured, test fails. | ||
| if not (act_interface_detail.get("authenticationMode") or act_interface_detail["sharedSecretProfile"]): | ||
| return f"{instance_data} Interface: {interface_data.name} Level: {interface_data.level} - Authentication mode not configured" |
There was a problem hiding this comment.
We may have this details in str()
Applicable to all this place
| { | ||
| "name": "success", | ||
| "test": VerifyISISInterfaceAuthMode, | ||
| "eos_data": [ |
There was a problem hiding this comment.
We don't want these details in eos date.
| }, | ||
| }, | ||
| { | ||
| "name": "failure-is-is-not-configured", |
There was a problem hiding this comment.
Suggested change
| "name": "failure-is-is-not-configured", | |
| "name": "skipped-ISIS-not-configured", |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Verifies IS-IS interfaces are running in the correct authentication mode.
Expected Results
Fixes #881
Checklist:
pre-commit run)tox -e testenv)