Re-works the update() method to avoid blocking #90
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was seeing weird issues following an unrelated failed OTA update where the NTP update() call would block the
loop()
method for 1024ms whilst packets timed out despite seeing replies going back to the ESP.This PR tweaks the
update()
method to work asynchronously rather than blocking things to implement the timeout which sorted things out for me.In addition, it also adds a backoff to timeout so we don't end up in a state constantly hammering the NTP server.
I'm using these changes in my project and, if you think they'll be generally useful, you're welcome to them under the same MIT license as the original work.
Cheers.