Cleaned up comments

arduino-libraries · Oct 5, 2023 · 7a841e4 · 7a841e4
1 parent 7671ad2
commit 7a841e4
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 20 deletions.
diff --git a/examples/ScienceJournal/ScienceJournal.ino b/examples/ScienceJournal/ScienceJournal.ino
@@ -78,7 +78,7 @@ void setup(){
   service.addCharacteristic(airQualityCharacteristic);
   /* _________________________________________________________SOUND_INTENSITY */
   service.addCharacteristic(sndIntensityCharacteristic);
-  /* ______!!! NOT AVAILABLE (should be delete?) !!!______________SOUND_PITCH */
+  /* _____________________________________________________________SOUND_PITCH */
   service.addCharacteristic(sndPitchCharacteristic);
   /* _________________________________________________________________INPUT_A */
   service.addCharacteristic(inputACharacteristic);
@@ -164,19 +164,8 @@ void updateSubscribedCharacteristics(){
 
 
   /* _______________________________________________________________PROXIMITY */
-  if (proximityCharacteristic.subscribed()){                                                    // need to be fixed
-
+  if (proximityCharacteristic.subscribed()){                                     
     proximityCharacteristic.writeValue(science_kit.getProximity());
-
-
-    /*
-    if (science_kit.getUltrasonicIsConnected()){
-      proximityCharacteristic.writeValue(science_kit.getDistance()*100.0);
-    }
-    else{
-      proximityCharacteristic.writeValue(-1.0);
-    }
-    */
   }
 
 
@@ -241,19 +230,14 @@ void updateSubscribedCharacteristics(){
     sndIntensityCharacteristic.writeValue(science_kit.getMicrophoneRMS());
   }
 
-  /* ______!!! NOT AVAILABLE (should be delete?) !!!______________SOUND_PITCH */
-  /* NOTE: pith is frequency (not available because FFT cannot be performed)  */
+  /* _____________________________________________________________SOUND_PITCH */
   if(sndPitchCharacteristic.subscribed()){
     sndPitchCharacteristic.writeValue(science_kit.getExternalTemperature());
   }
 
   /* _________________________________________________________________INPUT_A */
   if (inputACharacteristic.subscribed()){
     inputACharacteristic.writeValue(science_kit.getInputA());
-
-    /* NOTE_ OLD CODE USED FOR DEBUG
-      inputACharacteristic.writeValue(science_kit.getFrequency1());
-    */
   }
 
   /* _________________________________________________________________INPUT_B */

diff --git a/src/Arduino_ScienceKitCarrier.cpp b/src/Arduino_ScienceKitCarrier.cpp
@@ -19,7 +19,6 @@
 
 #include "Arduino_ScienceKitCarrier.h"
 
-// static members must be initialized externally the class definition
 short ScienceKitCarrier::sampleBuffer[MICROPHONE_BUFFER_SIZE];
 volatile int ScienceKitCarrier::samplesRead;