Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feedback macro #958

Merged
merged 4 commits into from
Feb 13, 2025
Merged

Feedback macro #958

merged 4 commits into from
Feb 13, 2025

Conversation

franzenr
Copy link
Contributor

@franzenr franzenr commented Feb 7, 2025

Moved feedback link up to top of page, and also turned it into a button.

I'm honestly not sure how I feel about it as a button, or if I think it would be better as just a link (which I implemented first, in this commit, screenshots below).

Version of feedback page using button

Version of feedback page using link just moved to top of page

move link for feedback survey to top of page, reduce length of text somewhat
switch to button
actually up version for real this time
@rosemm
Copy link
Contributor

rosemm commented Feb 7, 2025

I think this looks great! Here's a link to a Lia Live Editor that uses this version of the macros file, for testing: https://liascript.github.io/LiveEditor/?/edit/iQGFSbIl0yJSRm1dL9hm7880

Copy link
Contributor

@rosemm rosemm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I love it!

@franzenr franzenr merged commit 072fe5a into main Feb 13, 2025
2 checks passed
@franzenr franzenr deleted the feedback-macro branch February 13, 2025 19:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants