SAAS-28325: Enhance Host Assurance Policy Implementation and Testing & Improve GitHub Actions workflow for Terraform testing #294

shani-aqua · 2025-02-09T12:38:31Z

…Framework

Primary Changes:

Implement comprehensive data source acceptance testing framework
Restructure resource configuration to align with API specifications
Deprecate root-level 'enforce' field in favor of policy_settings.enforce
Set 'enabled' field to computed-only to match API behavior

Technical Improvements:

Testing Infrastructure:
- Add systematic test coverage for data source operations
- Implement both basic and full configuration test scenarios
- Add negative test cases for error handling validation
Resource Modifications:
- Migrate enforcement configuration to policy_settings block
- Update field computability to prevent state drift
- Enhance attribute validation logic
Documentation:
- Add detailed usage examples
- Update technical specifications
- Include migration guide for breaking changes
Code Quality:
- Improve error handling
- Enhance code organization
- Standardize testing patterns

Validation:

Executed full acceptance test suite
Confirmed API response handling
Validated state management

Related: SAAS-28325

CLAassistant · 2025-02-09T12:38:37Z

Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.

Shani Erman seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
_{You have signed the CLA already but the status is still pending? Let us recheck it.}

…Framework Primary Changes: - Implement comprehensive data source acceptance testing framework - Restructure resource configuration to align with API specifications - Deprecate root-level 'enforce' field in favor of policy_settings.enforce - Set 'enabled' field to computed-only to match API behavior Technical Improvements: 1. Testing Infrastructure: - Add systematic test coverage for data source operations - Implement both basic and full configuration test scenarios - Add negative test cases for error handling validation 2. Resource Modifications: - Migrate enforcement configuration to policy_settings block - Update field computability to prevent state drift - Enhance attribute validation logic 3. Documentation: - Add detailed usage examples - Update technical specifications - Include migration guide for breaking changes 4. Code Quality: - Improve error handling - Enhance code organization - Standardize testing patterns Validation: - Executed full acceptance test suite - Confirmed API response handling - Validated state management Related: SAAS-28325

BaruchBilanski · 2025-02-12T10:48:14Z

terraform-provider-aquasec

@shani-aqua
Please remove it, i would also consider adding to .gitignore to avoid future commits

Major changes: - Change from pull_request_target to pull_request to ensure tests run with PR's workflow version - Update checkout action from v2.3.3 to v4 for better security and performance - Add max-parallel: 1 to matrix strategy to run Terraform version tests sequentially - Update Terraform versions to test against: - Remove '0.13.7' - Add '0.14.11' and '1.5.3' - Clean up workflow structure and naming for better clarity - Rename job from "Matrix Test" to "Test Terraform {version}" - Remove redundant comments - Consistent formatting throughout the file These changes ensure tests run sequentially for each Terraform version while maintaining the ability to easily add/remove versions through the matrix config. The workflow now runs more reliably and uses the correct version from PR branches.

shani-aqua added the safe_to_test label Feb 9, 2025

shani-aqua force-pushed the SAAS-28325-tp-fix-aquasec-host-assurance-policy-resource-and-datasource branch from bc30f4c to 6a848ce Compare February 9, 2025 12:56

shani-aqua added safe_to_test and removed safe_to_test labels Feb 9, 2025

semyonmor added safe_to_test and removed safe_to_test labels Feb 9, 2025

shani-aqua added safe_to_test and removed safe_to_test labels Feb 9, 2025

shani-aqua force-pushed the SAAS-28325-tp-fix-aquasec-host-assurance-policy-resource-and-datasource branch from 1a4329a to 18802bb Compare February 9, 2025 15:17

shani-aqua added safe_to_test and removed safe_to_test labels Feb 9, 2025

shani-aqua force-pushed the SAAS-28325-tp-fix-aquasec-host-assurance-policy-resource-and-datasource branch from 18802bb to 1e603c1 Compare February 9, 2025 15:24

shani-aqua added safe_to_test and removed safe_to_test labels Feb 9, 2025

shani-aqua force-pushed the SAAS-28325-tp-fix-aquasec-host-assurance-policy-resource-and-datasource branch 2 times, most recently from eec955d to 1949ecb Compare February 9, 2025 15:38

shani-aqua added safe_to_test and removed safe_to_test labels Feb 9, 2025

shani-aqua force-pushed the SAAS-28325-tp-fix-aquasec-host-assurance-policy-resource-and-datasource branch from cabca52 to e27557f Compare February 10, 2025 11:31