Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor build e2e dapp guide #851

Merged
merged 5 commits into from
Mar 12, 2025
Merged

Refactor build e2e dapp guide #851

merged 5 commits into from
Mar 12, 2025

Conversation

0xmaayan
Copy link
Contributor

Description

Refactor the build e2e dapp guide to use create-aptos-dapp

Checklist

  • If any existing pages were renamed or removed:
    • Were redirects added to next.config.mjs?
    • Did you update any relative links that pointed to the renamed / removed pages?
  • Do all Lints pass?
    • Have you ran pnpm fmt?
    • Have you ran pnpm lint?

Copy link

vercel bot commented Mar 12, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
developer-docs-nextra ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 12, 2025 9:35pm

Copy link
Collaborator

@gregnazario gregnazario left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I trust that it works, may want someone else to spend the time to walk through it and see if there are any weird pitfalls

Copy link
Collaborator

@hariria hariria left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For these long-ish tutorials i feel like it makes sense to have the full completed source code available at the end of the page so people know what it should look like when they're done. There's a lot of steps that are easy to miss and frustrating to debug.

@0xmaayan
Copy link
Contributor Author

For these long-ish tutorials i feel like it makes sense to have the full completed source code available at the end of the page so people know what it should look like when they're done. There's a lot of steps that are easy to miss and frustrating to debug.

good idea. can add it

@0xmaayan
Copy link
Contributor Author

@0xmaayan
Copy link
Contributor Author

For these long-ish tutorials i feel like it makes sense to have the full completed source code available at the end of the page so people know what it should look like when they're done. There's a lot of steps that are easy to miss and frustrating to debug.

good idea. can add it

@hariria we actually link the source code in the first page, but need to change it as it is now a different code. I really dont want to put it on the aptos-core repo. Any objection of putting it in this dev repo?

@gregnazario
Copy link
Collaborator

@rtso Build is failing b/c of https://github.com/aptos-labs/aptos-indexer-processor-sdk/tree/main/aptos-indexer-processors-sdk - can you help?

That's okay, broken links are non-blocking. We can clean it up afterwards as well.

@0xmaayan 0xmaayan enabled auto-merge (squash) March 12, 2025 21:32
@0xmaayan 0xmaayan merged commit 1c5c553 into main Mar 12, 2025
5 of 6 checks passed
@0xmaayan 0xmaayan deleted the refactor_e2e_dapp_guide branch March 12, 2025 21:35
@0xmaayan 0xmaayan mentioned this pull request Mar 12, 2025
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants