Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the increase to 'minimum RLIMIT_NOFILE requirement' in the dev docs #836

Merged
merged 2 commits into from
Feb 28, 2025

Conversation

manudhundi
Copy link
Contributor

@manudhundi manudhundi commented Feb 27, 2025

Description

Checklist

  • If any existing pages were renamed or removed:
    • Were redirects added to next.config.mjs?
    • Did you update any relative links that pointed to the renamed / removed pages?
  • Do all Lints pass?
    • Have you ran pnpm fmt?
    • Have you ran pnpm lint?

Copy link

vercel bot commented Feb 27, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
developer-docs-nextra ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 27, 2025 10:28pm

@hariria
Copy link
Collaborator

hariria commented Feb 27, 2025

Will let you merge @manudhundi

@manudhundi
Copy link
Contributor Author

Will let you merge @manudhundi

Yes, lets wait for review from @msmouse

@@ -96,7 +96,7 @@ called \`Result::unwrap()\` on an \`Err\` value: Os { code: 24, kind: Uncategori
This means there were too many open files on your system. On many Unix systems you can increase the maximum number of open files by adding something like this to your `.zshrc`:

```bash filename="Terminal"
ulimit -n 32768
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the local network doesn't need so many fds, but I guess it's okay to just make them consistent.

we actually use the number 1048576 in many places in the codebase as I searched, maybe we should use that number?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

@manudhundi manudhundi merged commit 1346d01 into main Feb 28, 2025
5 checks passed
@manudhundi manudhundi deleted the manu/change_open_file_limit branch February 28, 2025 00:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants