readme setup fixes #827
Merged
readme setup fixes #827
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tippi-fifestarr
requested review from
gregnazario and
hariria
as code owners
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
![graphite-app[bot]](https://avatars.githubusercontent.com/in/158384?s=60&v=4){kind=small}
Comment on lines
67
to
79
| 2. Build Nextra | ||
|
|
||
| ```bash | ||
| npx turbo run build --filter={apps/nextra}... | ||
| pnpm run build | ||
| ``` | ||
|
|
||
| This will build `apps/nextra` and all local packages it depends on. | ||
|
|
||
| 3. Navigate to the correct subdirectory | ||
|
|
||
| ```sh | ||
| cd apps/nextra | ||
| ``` | ||
|
|
||
| 4. Run the development server | ||
| 3. Run the development server | ||
|
|
||
| ```sh | ||
| pnpm dev | ||
| pnpm run dev | ||
| ``` |
There was a problem hiding this comment.
Since the cd apps/nextra step was removed, please specify that these commands should be run from the project root directory. This helps avoid confusion, as running pnpm run build and pnpm run dev from a different directory would fail. Consider either:
- Adding a note like "From the project root directory:" before the commands, or
- Restoring the
cd apps/nextrastep
Either approach would prevent a common source of confusion for developers following these instructions.
Spotted by Graphite Reviewer
Is this helpful? React 👍 or 👎 to let us know.
gregnazario
approved these changes
Feb 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Made updates to readme file to match my experience of getting it to work (ex: removed prebuild step which errors)
Checklist
pnpm fmt?pnpm lint?