Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Improve OpenSSL version detection error handling in CLI installer #821

Closed
wants to merge 2 commits into from

Conversation

VolodymyrBg
Copy link

Description

Improved error handling in OpenSSL version detection for CLI installer

This PR enhances the error handling when detecting OpenSSL version during CLI installation. The changes include:

  1. Added validation for OpenSSL command output format
  2. Replaced generic Exception handling with specific exceptions (subprocess.SubprocessError, ValueError)
  3. Added detailed error messages that include the actual error description
  4. Improved code reliability and debugging capabilities

These changes will help users better understand installation issues related to OpenSSL version detection and make troubleshooting easier.

Checklist

  • If any existing pages were renamed or removed:
    • Were redirects added to next.config.mjs? (N/A - no pages renamed/removed)
    • Did you update any relative links that pointed to the renamed / removed pages? (N/A - no pages renamed/removed)
  • Do all Lints pass?
    • Have you ran pnpm fmt?
    • Have you ran pnpm lint?

Copy link

vercel bot commented Feb 18, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
developer-docs-nextra ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 18, 2025 8:50pm

Copy link
Collaborator

@gregnazario gregnazario left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Were you able to test this accordingly?

Hopefully people are not using 1.x.x anymore

@VolodymyrBg
Copy link
Author

@gregnazario Done

@gregnazario
Copy link
Collaborator

@gregnazario Done

@banool second eyes on this?

@VolodymyrBg
Copy link
Author

@banool

@gregnazario
Copy link
Collaborator

This PR #840 is basically the changes that need to happen, since 20.04 is being deprecated

@VolodymyrBg
Copy link
Author

@gregnazario so this one is going to be closed?

@gregnazario
Copy link
Collaborator

@gregnazario so this one is going to be closed?

Yes, but thanks for the contribution!

@gregnazario gregnazario closed this Mar 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants