Update documentation for entry functions #819
Merged
+5
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
vineethk
force-pushed
the
vk/entry-functions-update
branch
from
4ef76fe to
d41cb9e
Compare
gregnazario
reviewed
Feb 13, 2025
| Entry functions can take primitive types, String, and vector arguments but cannot take Structs (e.g. Option). They also | ||
| must not have any return values. | ||
| Entry functions can accept parameters that are: primitive types, reference to a `signer`, vectors (where the element type is itself acceptable), | ||
| and certain standard library types such as `String`, `Object`, `Option`, `FixedPoint32`, `FixedPoint64`. |
There was a problem hiding this comment.
FixedPoint might be supported, but I'm unsure how it's BCS encoded.
Let's skip it for now?
There was a problem hiding this comment.
Sounds good - I was going based on the code in the extended checker.
gregnazario
approved these changes
Feb 13, 2025
vineethk
force-pushed
the
vk/entry-functions-update
branch
from
d41cb9e to
cb808e4
Compare
rahxephon89
approved these changes
Feb 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Entry functions allow more than what was previously documented.
Also includes fixes to satisfy the link checker.
Closes aptos-labs/aptos-core#14571
Checklist
pnpm fmt?pnpm lint?