Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[move-book] Extending Book by Move 2.0 Documentation #567

Merged
merged 5 commits into from
Aug 31, 2024
Merged

Conversation

wrwg
Copy link
Contributor

@wrwg wrwg commented Aug 27, 2024

Description

Adds documentation derived from our internal preparation documents. Also adds an overview page for Move 2 which links to other sections in the book.

One way to view this is via the latest vercel preview deployment which can be seen in the PR activity.

Checklist

[All CI tests passed]

  • Do all Lints pass?
    • Have you ran pnpm spellcheck?
    • Have you ran pnpm fmt?
    • Have you ran pnpm lint?

Copy link

vercel bot commented Aug 27, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
developer-docs-nextra ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 30, 2024 5:20am

Copy link
Contributor Author

wrwg commented Aug 27, 2024

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @wrwg and the rest of your teammates on Graphite Graphite

Copy link
Collaborator

@hariria hariria left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Just some nits

Copy link
Contributor

@brmataptos brmataptos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A bunch of suggestions.

Copy link
Contributor

@brmataptos brmataptos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I still think you should fix the code example, but it's generally quite good now.

@wrwg
Copy link
Contributor Author

wrwg commented Aug 28, 2024

I still think you should fix the code example, but it's generally quite good now.

Can you elaborate which code example you think should be fixed? For field assignment, one actually uses

borrow_mut(something).field = x

... no *, so that one I did revert after accepting first, but then verifying it. In fact one needs to do

*borrow_mut(something) = x

Only fields have this treatment. Somehow the parser already makes decisions here.

wrwg added 4 commits August 29, 2024 12:12
Adds documentation derived from our internal preparation documents. Also adds an overview page for Move 2 which links to other sections in the book.
@wrwg wrwg merged commit 8adea60 into main Aug 31, 2024
5 checks passed
@wrwg wrwg deleted the wrwg/move-2-book branch August 31, 2024 02:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants