-
Notifications
You must be signed in to change notification settings - Fork 133
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[move-book] Extending Book by Move 2.0 Documentation #567
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
This stack of pull requests is managed by Graphite. Learn more about stacking. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great! Just some nits
apps/nextra/pages/en/build/smart-contracts/book/coding-conventions.mdx
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A bunch of suggestions.
apps/nextra/pages/en/build/smart-contracts/book/structs-and-resources.mdx
Outdated
Show resolved
Hide resolved
apps/nextra/pages/en/build/smart-contracts/book/structs-and-resources.mdx
Outdated
Show resolved
Hide resolved
apps/nextra/pages/en/build/smart-contracts/book/global-storage-operators.mdx
Outdated
Show resolved
Hide resolved
apps/nextra/pages/en/build/smart-contracts/book/global-storage-operators.mdx
Show resolved
Hide resolved
apps/nextra/pages/en/build/smart-contracts/book/global-storage-operators.mdx
Outdated
Show resolved
Hide resolved
apps/nextra/pages/en/build/smart-contracts/book/structs-and-resources.mdx
Outdated
Show resolved
Hide resolved
apps/nextra/pages/en/build/smart-contracts/book/structs-and-resources.mdx
Outdated
Show resolved
Hide resolved
apps/nextra/pages/en/build/smart-contracts/book/structs-and-resources.mdx
Outdated
Show resolved
Hide resolved
apps/nextra/pages/en/build/smart-contracts/book/structs-and-resources.mdx
Outdated
Show resolved
Hide resolved
apps/nextra/pages/en/build/smart-contracts/book/structs-and-resources.mdx
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I still think you should fix the code example, but it's generally quite good now.
Can you elaborate which code example you think should be fixed? For field assignment, one actually uses
... no
Only fields have this treatment. Somehow the parser already makes decisions here. |
Adds documentation derived from our internal preparation documents. Also adds an overview page for Move 2 which links to other sections in the book.
Description
Adds documentation derived from our internal preparation documents. Also adds an overview page for Move 2 which links to other sections in the book.
One way to view this is via the latest vercel preview deployment which can be seen in the PR activity.
Checklist
[All CI tests passed]
pnpm spellcheck
?pnpm fmt
?pnpm lint
?