Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update wallet adapter docs on AIP-62 standard #353

Merged
merged 2 commits into from
May 21, 2024
Merged

Conversation

0xmaayan
Copy link
Contributor

Description

Checklist

  • Do all Lints pass?
    • [] Have you ran pnpm spellcheck?
    • [] Have you ran pnpm fmt?
    • [] Have you ran pnpm lint?

Copy link

vercel bot commented May 21, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
developer-docs-nextra ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 21, 2024 8:54pm

@0xmaayan 0xmaayan requested a review from hariria May 21, 2024 00:57
Copy link

netlify bot commented May 21, 2024

Deploy Preview for aptos-developer-docs ready!

Name Link
🔨 Latest commit e48f0c1
🔍 Latest deploy log https://app.netlify.com/sites/aptos-developer-docs/deploys/664d086b81bf87000813cd84
😎 Deploy Preview https://deploy-preview-353--aptos-developer-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Collaborator

@gregnazario gregnazario left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you update nextra as well?

@0xmaayan 0xmaayan force-pushed the update_adapter_docs branch from 7298f6e to bfc2e09 Compare May 21, 2024 19:15
@0xmaayan
Copy link
Contributor Author

can you update nextra as well?

Done. also, added more docs on wallets-opt-in support - please review


Sometimes, a dapp might want to specifically opt in to certain wallets and display only those. For this, you should be able to pass an `optInWallets` array to the `AptosWalletAdapterProvider` with the names of the wallets you wish to include in your dapp.

```js
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should probably be tsx or jsx

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

@0xmaayan 0xmaayan force-pushed the update_adapter_docs branch from 2220c90 to e48f0c1 Compare May 21, 2024 20:47
@0xmaayan 0xmaayan merged commit f314b5a into main May 21, 2024
8 checks passed
@0xmaayan 0xmaayan deleted the update_adapter_docs branch May 21, 2024 20:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants