Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix running move scripts with ts sdk #345

Merged
merged 1 commit into from
May 17, 2024
Merged

Fix running move scripts with ts sdk #345

merged 1 commit into from
May 17, 2024

Conversation

0xmaayan
Copy link
Contributor

Description

Checklist

  • Do all Lints pass?
    • [] Have you ran pnpm spellcheck?
    • [] Have you ran pnpm fmt?
    • [] Have you ran pnpm lint?

Copy link

vercel bot commented May 17, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
developer-docs-nextra ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 17, 2024 8:19pm

@0xmaayan 0xmaayan requested review from hariria and removed request for gregnazario and 0xZihan May 17, 2024 20:14
@@ -497,8 +497,8 @@ To retrieve the balance of the `PrimaryFungibleStore` of the paired FA of coin t

1. Call `paired_metadata<CoinType>()` to obtain the paired FA metadata object address, which is immutable, allowing for storage or caching to enhance performance.
2. Retrieve the balance of the paired FA:
* Call [getCurrentFungibleAssetBalances](https://github.com/aptos-labs/aptos-ts-sdk/blob/c01a26ff899235fac1c31c6cc3fe504b764e5b91/src/api/fungibleAsset.ts#L115);
* Alternatively, determine the address of the primary `FungibleStore`, which is deterministic as `sha3_256(32-byte account address | 32-byte metadata object address | 0xFC)`, and obtain the `FungibleStore` resource at this address to fetch the balance. If it is non-zero, this is the final balance of this FA. Otherwise, try to get `ConcurrentFungibleBalance` resource at the same address and get the balance there instead or 0 If `ConcurrentFungibleBalance` does not exist.
- Call [getCurrentFungibleAssetBalances](https://github.com/aptos-labs/aptos-ts-sdk/blob/c01a26ff899235fac1c31c6cc3fe504b764e5b91/src/api/fungibleAsset.ts#L115);
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

from lint/fmt

Copy link

netlify bot commented May 17, 2024

Deploy Preview for aptos-developer-docs ready!

Name Link
🔨 Latest commit 407d15e
🔍 Latest deploy log https://app.netlify.com/sites/aptos-developer-docs/deploys/6647baa3a641700008c0e423
😎 Deploy Preview https://deploy-preview-345--aptos-developer-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@@ -6,7 +6,7 @@ export default {
title: "Setup",
},
"---": {
"type": "separator"
type: "separator",
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

from lint/fmt

@0xmaayan 0xmaayan merged commit 115cfdf into main May 17, 2024
8 checks passed
@0xmaayan 0xmaayan deleted the fix_scripts_ts_sdk branch May 17, 2024 20:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants