-
Notifications
You must be signed in to change notification settings - Fork 133
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Broken Link Checker #338
Broken Link Checker #338
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
✅ Deploy Preview for aptos-developer-docs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
.github/workflows/link-check.yml
Outdated
- name: Run Lychee Link Checker | ||
uses: lycheeverse/lychee-action@v1 | ||
with: | ||
args: --base . --verbose --no-progress './apps/nextra/**/*.mdx' './apps/nextra/**/*.html' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We probably need to figure out how to ignore localhost
links.
This is why the broken link checker wasn't blocking before
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you give an example of what you mean by a local host link (I know what it is but when would it arise in the docs?)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just take a look at the output from the PR run
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh lmfao i see thanks. @kshitjee maybe something like this lycheeverse/lychee#1384 (comment)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it ignores localhost links now, check latest workflow run
Description
Add github workflow to fail in CI if broken links are detected in any HTML or Markdown files under apps/nextra.
Checklist
pnpm spellcheck
?pnpm fmt
?pnpm lint
?