-
Notifications
You must be signed in to change notification settings - Fork 133
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix the organization of Nextra #335
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
✅ Deploy Preview for aptos-developer-docs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm, let's fix the html files that got converted to mdx
move: "Move", | ||
"smart-contracts": "Smart Contracts", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we just changed this.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you follow up with me async about this change? I think that smart-contracts is a more useful name for discovery for folks who don't know what Move is, and folks who do know what Move is will equally know this is the right section for them.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's just get this change in, and we can talk after about it.
apps/nextra/pages/en/build/cli/use-cli/replay-past-transactions.mdx
Outdated
Show resolved
Hide resolved
.../cli/use-cli/working-with-move-contracts/local-simulation-benchmarking-and-gas-profiling.mdx
Outdated
Show resolved
Hide resolved
apps/nextra/pages/en/build/move/book/global-storage-structure.mdx
Outdated
Show resolved
Hide resolved
apps/nextra/pages/en/build/smart-contracts/learn-move/advanced-guides/cryptography.mdx
Outdated
Show resolved
Hide resolved
apps/nextra/pages/en/build/smart-contracts/learn-move/book/standard-library.mdx
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the hard work on this. Couple things I noticed that may need some closer attention:
- I think the links on the landing page need to be updated as well. i.e., the links in
GET STARTED WITH THESE MOVE EXAMPLES
for each section (Coins, Objects, etc.) as well as theDISCOVER BLOCKCHAIN FEATURES ON APTOS
section - We need to find another place to put the
Wallet
markdown doc inStandards
Why do we need to find another place to put the |
The Wallet standards are unrelated to Smart Contracts |
nit: I noticed when merging that we're adding → to every Card.Title. That seems really easy to forget over time, plus a bit annoying to find that character to copy + paste when adding new cards - @hariria would it make sense to add that to the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yep I can modify Card.Title in a future PR to take in a -> arrow prop.
--- | ||
title: "SDKs" | ||
--- | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could we leave this here?
Description
Moved the pages into the New Docs Format.
Wrote a script to automatically fix links called
update-relative-links.py
. Used it in conjunction withmarkdown-link-checker
to verify that once moved all the relative links worked. (Still some external links which need to be fixed, and a couple of pages which need to be migrated - see below).Remaining issues to be resolved in future PRs:
Checklist
Pages that still need migrating (Overall, not in this PR - but they were broken links)
Remaining TODOs on migration effort
Adding a reference to “Standards” to the top-level (in addition to the Smart Contracts section.
Write an Advanced Guides index page.
local-network.md in SDK section
Remove the "TODOs" to fix links. (Didn't see a great search to find them all before I was heading to bed - @gregnazario do you know the various formats you were using for this?)
Do all Lints pass?
pnpm spellcheck
?pnpm fmt
?pnpm lint
?