. e removing 3.12

Co-Authored-By: 4dsherwood <4dsherwood@users.noreply.github.com> Co-Authored-By: blade290 <43077216+blade290@users.noreply.github.com>
approvals · Apr 21, 2024 · 952ad2f · 952ad2f
1 parent a2f1c88
commit 952ad2f
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 1 deletion.
diff --git a/.github/workflows/test.yml b/.github/workflows/test.yml
@@ -9,7 +9,7 @@ jobs:
     strategy:
       fail-fast: true
       matrix:
-        python-version: [3.8, 3.9, "3.10", "3.11", "3.12"]
+        python-version: [3.8, 3.9, "3.10", "3.11"]
         os: [macos-latest, ubuntu-latest, windows-latest]
 
     steps:

diff --git a/TODO.md b/TODO.md
@@ -25,6 +25,7 @@ Inline Approvals Bugs
 2. [ ] check all reporters return True or False
     4. [ ] add mypy to the CI (type hints exist and they are being inforced)
 3. [ ] make it so that approvals works with Python 12
+   4. 2024-04-21 - The issue is in MRJob. Need probably need to move to spark. this should probably be done with Jacqueline present
 4. [ ] Improve verify_all for no header
         Expects VerifyAll to have a header
         this is mandatory For PYthon Approval Tests