Skip to content

Commit

Permalink
. t added full cycle tests
Browse files Browse the repository at this point in the history
Co-Authored-By: 4dsherwood <4dsherwood@users.noreply.github.com>
Co-Authored-By: Susan Fung <38925660+susanfung@users.noreply.github.com>
Co-Authored-By: Nitsan Avni <nitsanav@gmail.com>
Co-Authored-By: Nazee Hajebi <2491283+NazeeHajebi@users.noreply.github.com>
Co-Authored-By: bhargavgundu <7643639+bhargavgundu@users.noreply.github.com>
  • Loading branch information
6 people committed May 12, 2024
1 parent 0a88a14 commit 1c941ef
Show file tree
Hide file tree
Showing 2 changed files with 43 additions and 0 deletions.
34 changes: 34 additions & 0 deletions mob-sessions-retros/2024-05-12 options.add_reporter.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,34 @@
# mini retro

Nitsan
- Appreciated: working on the idea, having new person
- Curious: How it works end to end

Diana
- Observed: Bhargav is very good with Python, also - asked when did not understand.
- at the start - a discussion - Llewellyn suggested we skipped the discussion / descritpion / overview and go straight to testing
- going forward

Nazee
- took some time to figure out what to work on
- What is it that we're doing? a description
- Llewelyn added "current behavior": very helpful
- Prefer having a written description of the task at hand
- is copilot really helping us?

Susan
- Liked: breaking down - checking current impl and then the new thing we want to do
- Noticed: "what's the next intention?"
- Consider going forward: saying "This was my next intent"

Llewellyn
- Liked: the functionality is nice, differentiate between override and adding
- Noticed: adding the comments helped, and things became easier
- Think we could've switched to "ping pong" rotations at some point, maybe after completing the first comment

Bhargav
- Liked: incremental breakdown - easy to understand
- am new to approvaltests
- TIL: Copilot is so good! Life changing
- TIL: `str`
- suggest going forward: taper off with the intent
9 changes: 9 additions & 0 deletions tests/test_inline_approvals.py
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,7 @@
from approvaltests.inline.inline_options import InlineOptions
from approvaltests.inline.parse_docstring import parse_docstring
from approvaltests.reporters.report_quietly import ReportQuietly
from build.lib.approvaltests.reporters.report_with_beyond_compare import ReportWithPycharm, ReportWithBeyondCompare


def get_approved_via_doc_string():
Expand Down Expand Up @@ -173,3 +174,11 @@ def test_bug_blank_lines():
"""
verify("\n\ntest bug with blank lines\n\n\n\n", options=Options().inline())


def test_inline_with_additional_reporter():
"""
hello
world
"""
verify("hello\nworld", options=(Options().inline().add_reporter(ReportWithBeyondCompare())))

0 comments on commit 1c941ef

Please sign in to comment.