Skip to content

Commit

Permalink
. t Confirmed blank lines work
Browse files Browse the repository at this point in the history
Co-Authored-By: 4dsherwood <4dsherwood@users.noreply.github.com>
Co-Authored-By: Susan Fung <38925660+susanfung@users.noreply.github.com>
Co-Authored-By: blade290 <43077216+blade290@users.noreply.github.com>
Co-Authored-By: T. E. Green <78671457+Tegsy@users.noreply.github.com>
  • Loading branch information
5 people committed Mar 24, 2024
1 parent 2857e91 commit 19533b6
Show file tree
Hide file tree
Showing 2 changed files with 18 additions and 7 deletions.
12 changes: 5 additions & 7 deletions TODO.md
Original file line number Diff line number Diff line change
Expand Up @@ -14,18 +14,16 @@ Try to make the smallest change possible, then rotate


Inline Approvals Bugs
1. [? ] fix inline bug with whitespace (trailing and leading as well as blank lines)
2. [ ] fix inline bug with blank lines
2. [ ] rename all of the reporters to start with the word report
3. [ ] check all reporters return True or False
1. [ ] rename all of the reporters to start with the word report
2. [ ] check all reporters return True or False
4. [ ] add mypy to the CI (type hints exist and they are being inforced)
4. [ ] make it so that approvals works with Python 12
5. [ ] Improve verify_all for no header
3. [ ] make it so that approvals works with Python 12
4. [ ] Improve verify_all for no header
Expects VerifyAll to have a header
this is mandatory For PYthon Approval Tests
added an example to Test_inline_approvals.py
see: def test_uppercase_with_verify_all():
6. [ ] expand functionality of parse_doc_string NOTE: this is WIP from 3/3/24 parse inputs
5. [ ] expand functionality of parse_doc_string NOTE: this is WIP from 3/3/24 parse inputs
2. [ ] =>, :
3. [ ] maybe not only docstring but any text or approved file?
4. [ ] multiple parameters 1, 2, 3 ->
Expand Down
13 changes: 13 additions & 0 deletions tests/test_inline_approvals.py
Original file line number Diff line number Diff line change
Expand Up @@ -178,3 +178,16 @@ def test_trailing_whitespace():
# Note: Pycharm will remove the trailing whitespaces, to disable this go to:
# File -> Settings -> Editor -> General -> On Save -> [ ] Remove trailing spaces
verify("4 trailing whitespaces ", options=Options().inline(show_code=False))

# 2. [ ] fix inline bug with blank lines <- from todo list
def test_bug_blank_lines():
"""
test bug with blank lines
"""
verify("\n\ntest bug with blank lines\n\n\n\n", options=Options().inline(show_code=True))

1 comment on commit 19533b6

@nitsanavni
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

awesome 🤩

Please sign in to comment.