- r use querable

Co-Authored-By: Jay Bazuzi <jay@bazuzi.com>
approvals · Mar 10, 2025 · db3dd86 · db3dd86
1 parent 9f8b9b6
commit db3dd86
Showing 1 changed file with 6 additions and 12 deletions.
diff --git a/approvaltests/src/main/java/org/approvaltests/namer/AttributeStackSelector.java b/approvaltests/src/main/java/org/approvaltests/namer/AttributeStackSelector.java
@@ -111,22 +111,16 @@ private boolean isJunit3Test(Class<?> clazz)
   private boolean isTestAttribute(Class<?> clazz, String methodName)
   {
     Queryable<Method> methods = getMethodsByName(clazz, methodName);
-    for (Method method : methods)
-    {
-      for (Class<? extends Annotation> attribute : attributes)
-      {
-        if (method.isAnnotationPresent(attribute))
-        {
-          checkConditionsForAttribute(attribute);
-          return true;
-        }
-      }
-    }
-    return false;
+    Class<? extends Annotation> attribute = Queryable.as(attributes) //
+        .first(a -> methods.any(m -> m.isAnnotationPresent(a)));
+    checkConditionsForAttribute(attribute);
+    return attribute != null;
   }
   // TODO: clean this up, should be pluggable
   private static void checkConditionsForAttribute(Class<? extends Annotation> attribute)
   {
+    if (attribute == null)
+    { return; }
     if ("org.junit.jupiter.api.TestFactory".equals(attribute.getName()))
     {
       if (!isDynamicWrapperPresent())