Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SPARK-51297][DOCS] Fixed the scope of the query option in sql-data-sources-jdbc.md #50048

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

llphxd
Copy link

@llphxd llphxd commented Feb 22, 2025

What changes were proposed in this pull request?

The documentation shows that the scope of jdbc's option is read/write, but after looking at the source code and testing it, it should actually only be read.
This error has persisted for multiple versions and is still not fixed.

source code:

s"Option '$JDBC_QUERY_STRING' is not applicable while writing.")

code snippet:
SnBKfLO4Fu
test snippet:
WWWQRqH6jS

Why are the changes needed?

This avoids user confusion about the use of this option and avoids errors in its use

Does this PR introduce any user-facing change?

No

How was this patch tested?

No testing required, just modifying the document

Was this patch authored or co-authored using generative AI tooling?

No

@github-actions github-actions bot added the DOCS label Feb 22, 2025
Copy link
Contributor

@beliefer beliefer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch!. cc @dilipbiswal
Because this is a bug, could you create an issue ?

@beliefer
Copy link
Contributor

@llphxd
Copy link
Author

llphxd commented Feb 22, 2025

Please config your GA. https://github.com/apache/spark/pull/50048/checks?check_run_id=37647515971

I enabled GA and triggered GA with an empty commit, is that correct?

@llphxd
Copy link
Author

llphxd commented Feb 22, 2025

Good catch!. cc @dilipbiswal Because this is a bug, could you create an issue ?

I would love to, but I failed to register jira and have to wait 24 hours. So I'll create the issue later.

@beliefer
Copy link
Contributor

I would love to, but I failed to register jira and have to wait 24 hours. So I'll create the issue later.

Please tell me if the issue is ready.

@llphxd
Copy link
Author

llphxd commented Feb 23, 2025

I would love to, but I failed to register jira and have to wait 24 hours. So I'll create the issue later.

Please tell me if the issue is ready.

The issue is now ready.
https://issues.apache.org/jira/browse/SPARK-51297

@beliefer beliefer changed the title [MINOR][DOCS] Fixed the scope of the query option in sql-data-sources-jdbc.md [SPARK-51297][DOCS] Fixed the scope of the query option in sql-data-sources-jdbc.md Feb 23, 2025
Copy link
Contributor

@beliefer beliefer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants