-
Notifications
You must be signed in to change notification settings - Fork 28.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[SPARK-51297][DOCS] Fixed the scope of the query option in sql-data-sources-jdbc.md #50048
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good catch!. cc @dilipbiswal
Because this is a bug, could you create an issue ?
Please config your GA. |
I enabled GA and triggered GA with an empty commit, is that correct? |
I would love to, but I failed to register jira and have to wait 24 hours. So I'll create the issue later. |
Please tell me if the issue is ready. |
The issue is now ready. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. cc @yaooqinn @dongjoon-hyun
What changes were proposed in this pull request?
The documentation shows that the scope of jdbc's option is read/write, but after looking at the source code and testing it, it should actually only be read.
This error has persisted for multiple versions and is still not fixed.
source code:
spark/sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/jdbc/JDBCOptions.scala
Line 287 in a661f9f
code snippet:
test snippet:
Why are the changes needed?
This avoids user confusion about the use of this option and avoids errors in its use
Does this PR introduce any user-facing change?
No
How was this patch tested?
No testing required, just modifying the document
Was this patch authored or co-authored using generative AI tooling?
No