Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SEDONA-715] Add apache zeppelin notebook support for the docker image #1826

Merged
merged 4 commits into from
Feb 28, 2025

Conversation

sshiv012
Copy link
Contributor

@sshiv012 sshiv012 commented Feb 24, 2025

Did you read the Contributor Guide?
Yes, I have read Contributor Rules and Contributor Development Guide

Is this PR related to a JIRA ticket?
Yes, the URL of the associated JIRA ticket is https://issues.apache.org/jira/browse/SEDONA-715. The PR name follows the format [SEDONA-XXX] my subject.

What changes were proposed in this PR?
Added Zeppelin notebook support for the sedona docker image along with visualization helium plugin

How was this patch tested?
Tested locally by building the image and running it. Visualized with the sample notebook that has been bundled with the commit.

Did this PR include necessary documentation updates? Yes, added additional information that may help the users.

Did you read the Contributor Guide?
Yes, I have read Contributor Rules and Contributor Development Guide

Is this PR related to a JIRA ticket?
Yes, the URL of the associated JIRA ticket is https://issues.apache.org/jira/browse/SEDONA-715. The PR name follows the format [SEDONA-XXX] my subject.

What changes were proposed in this PR?
Added Zeppelin notebook support for the sedona docker image along with visualization helium plugin

How was this patch tested?
Tested locally by building the image and running it. Visualized with the sample notebook that has been bundled with the commit.

Did this PR include necessary documentation updates?
Yes, added additional information that may help the users.
1. Modified dockerfile to use the new format for ENV
2. Added config files for zeppelin to improve user experience
3. Modified documentation to support the changes.
@jiayuasu
Copy link
Member

@sshiv012 please run pre-commit run --all-files locally to fix lint issues

@jiayuasu
Copy link
Member

@sshiv012 Your last commit seems to break the CI. Please fix it. Thanks!

@sshiv012
Copy link
Contributor Author

If the files already have the +x flag set, git update-index --chmod=+x does nothing and git thinks there's nothing to commit, even though the flag isn't being saved into the repo. Had to remove the flag, run the git command, then put the flag back. Also set git config core.filemode to false.

@jiayuasu jiayuasu added this to the sedona-1.7.1 milestone Feb 28, 2025
@jiayuasu jiayuasu merged commit 5e6a673 into apache:master Feb 28, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants