Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CI] Add pre-commit hook shellcheck-py to lint shell files #1626

Merged
merged 1 commit into from
Oct 24, 2024

Conversation

jbampton
Copy link
Member

https://github.com/shellcheck-py/shellcheck-py

https://www.shellcheck.net/

https://github.com/koalaman/shellcheck

Did you read the Contributor Guide?

Is this PR related to a JIRA ticket?

  • No

What changes were proposed in this PR?

Added another check/test to our pre-commit framework to check the syntax of shell files.

Cleaned up and standardized some shell files.

How was this patch tested?

Ran locally: pre-commit run --all-files

Did this PR include necessary documentation updates?

  • No, this PR does not affect any public API so no need to change the documentation.

@jbampton jbampton requested a review from jiayuasu as a code owner October 11, 2024 19:34
@jbampton jbampton changed the title Add pre-commit hook shellcheck-py to lint shell files [CI] Add pre-commit hook shellcheck-py to lint shell files Oct 12, 2024
@jbampton jbampton closed this Oct 12, 2024
@jbampton jbampton reopened this Oct 12, 2024
@jiayuasu jiayuasu merged commit e7b48b4 into apache:master Oct 24, 2024
12 of 19 checks passed
@jbampton jbampton deleted the pre-commit-add-shellcheck branch October 24, 2024 04:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants