-
Notifications
You must be signed in to change notification settings - Fork 14.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MINOR: Remove zk from replica_verification_test #19015
base: trunk
Are you sure you want to change the base?
MINOR: Remove zk from replica_verification_test #19015
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this PR, left a comment
@@ -20,7 +20,6 @@ | |||
from ducktape.tests.test import Test | |||
|
|||
from kafkatest.services.verifiable_producer import VerifiableProducer | |||
from kafkatest.services.zookeeper import ZookeeperService | |||
from kafkatest.services.kafka import KafkaService, quorum | |||
from kafkatest.services.replica_verification_tool import ReplicaVerificationTool | |||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you also rename num_zk
this field?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
https://issues.apache.org/jira/browse/KAFKA-18582
This is tracking by this issue.
I don't dig in it, but this PR seems to cause another failure
|
Hi @chia7712 |
We could remove zk from the
replica_verification_test
since ak has eliminated zk.Committer Checklist (excluded from commit message)