MINOR: Don't allow cloning a ProducerStateEntry with a different producer id #18990
+5
−6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
triage
BewareMyPower
force-pushed
the
minor-refactor-updated-entry
branch
from
fa85a56 to
0d9492b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
ProducerStateEntryhas been refactored several times and nowProducerAppendInfo#updatedEntryis created by calling thewithProducerIdAndBatchMetadataoncurrentEntry. However, this method is confusing because the 1st parameter is the producer id, which means this method could be used to createupdatedEntrywith a different producer id withcurrentEntry. However, this case should never happen.Committer Checklist (excluded from commit message)