-
Notifications
You must be signed in to change notification settings - Fork 14.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
KAFKA-18836 Make ConsumerGroupMetadata an interface #18977
base: trunk
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @pszymczyk
Thanks for the patch
According to the ticket, this change should have a KIP first since this will introduce a change to the public API.
Please refer to the following link for further information:
https://cwiki.apache.org/confluence/display/KAFKA/Kafka+Improvement+Proposals
Hi @frankvicky |
* Note: Any change to this class is considered public and requires a KIP. | ||
*/ | ||
public class ConsumerGroupMetadata { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We cannot do it this way. For Kafka 4.1, we need to keep the class as-is, to maintain backward compatibility. We should only deprecate both constructors, and update the JavaDocs saying, that this class will become an interface in the future, ie, Apache Kafka 5.0.
The KIP should lay out this two step approach, and if the KIP gets accepted, we should file a follow up ticket for AK 5.0 release, that would do the actual code change from class
to interface
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sure, makes sense, I will provide a KIP and update the PR.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Implementation for KAFKA-18836 improvement.
KIP-1136