Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

KAFKA-18379: Enforce resigned cannot transition to any other state in same epoch #18789

Open
wants to merge 1 commit into
base: trunk
Choose a base branch
from
Open

KAFKA-18379: Enforce resigned cannot transition to any other state in same epoch #18789

wants to merge 1 commit into from
+10 −4

Conversation

frankvicky
Copy link
Contributor

JIRA: KAFKA-18379
For further details, please refer to KIP-996 and #18240 (comment).

In short, this PR adds a check for the transition from the resigned state to other states to prevent a resigned leader from accidentally becoming its own follower in the same epoch, which would create an invalid circular reference.

Committer Checklist (excluded from commit message)

  • Verify design and implementation
  • Verify test coverage and CI build status
  • Verify documentation (including upgrade notes)

@github-actions github-actions bot added triage PRs from the community kraft small Small PRs labels Feb 3, 2025
@frankvicky
Copy link
Contributor Author

Hi @ahuang98
Please take a look when you have a free cycle.
Many thanks.

@frankvicky frankvicky marked this pull request as draft February 4, 2025 08:07
@frankvicky frankvicky marked this pull request as ready for review February 4, 2025 08:25
@frankvicky frankvicky force-pushed the KAFKA-18379 branch 4 times, most recently from 3a404db to 54118c5 Compare February 8, 2025 06:35
@github-actions GitHub Actions
Copy link

A label of 'needs-attention' was automatically added to this PR in order to raise the
attention of the committers. Once this issue has been triaged, the triage label
should be removed to prevent this automation from happening again.

@github-actions GitHub Actions
Copy link

A label of 'needs-attention' was automatically added to this PR in order to raise the
attention of the committers. Once this issue has been triaged, the triage label
should be removed to prevent this automation from happening again.

@github-actions GitHub Actions
Copy link

A label of 'needs-attention' was automatically added to this PR in order to raise the
attention of the committers. Once this issue has been triaged, the triage label
should be removed to prevent this automation from happening again.

@github-actions GitHub Actions
Copy link

A label of 'needs-attention' was automatically added to this PR in order to raise the
attention of the committers. Once this issue has been triaged, the triage label
should be removed to prevent this automation from happening again.

@github-actions GitHub Actions
Copy link

A label of 'needs-attention' was automatically added to this PR in order to raise the
attention of the committers. Once this issue has been triaged, the triage label
should be removed to prevent this automation from happening again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
ci-approved kraft needs-attention small Small PRs triage PRs from the community
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@frankvicky @FrankYang0529