Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: improve license header checker confs and pre-check header when validating #2445

Merged
merged 8 commits into from
Feb 23, 2024
Merged

chore: improve license header checker confs and pre-check header when validating #2445

Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
c592f60
improve license header checker confs
VGalaxies Feb 6, 2024
f320ca9
typo
VGalaxies Feb 6, 2024
79367bf
verify -> validate
VGalaxies Feb 7, 2024
c9548d8
Merge branch 'master' into license-header
VGalaxies Feb 7, 2024
17cc0f0
update rat exclude files
VGalaxies Feb 7, 2024
b75ca0c
empty commit
VGalaxies Feb 7, 2024
74f4bf0
update rat exclude files
VGalaxies Feb 7, 2024
e3d9fea
update rat exclude files
VGalaxies Feb 7, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -179,6 +179,7 @@
<exclude>**/rocksdb-*/**</exclude>
<exclude>**/hbase-*/**</exclude>
<exclude>**/apache-cassandra-*/**</exclude>
<exclude>**/pid</exclude>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe should exclude the whole generated dir? (ignore the suggestion if it's just a test)

Copy link
Contributor Author

@VGalaxies VGalaxies Feb 7, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These files or directories are excluded because validation is performed before using mvn test, which may include data generated from previous tests or files generated during server runtime, such as:

/home/runner/work/incubator-hugegraph/incubator-hugegraph/hugegraph-server/apache-hugegraph-incubating-1.2.0/bin/pid
/home/runner/work/incubator-hugegraph/incubator-hugegraph/hugegraph-server/hugegraph-test/rocksdb-data/graph/m/OPTIONS-000015

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fine

</excludes>
<consoleOutput>true</consoleOutput>
</configuration>
Expand Down
Loading