[GLUTEN-8966][VL] Propagate HashAggregate's ignoreNullKeys when possible #8967
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Run Gluten Clickhouse CI on x86 |
WangGuangxin
force-pushed
the
hashagg_nullkey
branch
from
57536bf to
455f62a
Compare
|
Run Gluten Clickhouse CI on x86 |
WangGuangxin
force-pushed
the
hashagg_nullkey
branch
from
455f62a to
73199a8
Compare
|
Run Gluten Clickhouse CI on x86 |
| val s = | ||
| """ | ||
| |select count(1) from | ||
| | (select l_orderkey, max(l_partkey) from lineitem group by l_orderkey) a |
There was a problem hiding this comment.
What if agg offload but join fallback?
|
|
||
| test("aggregate on join keys can set ignoreNullKeys") { | ||
| val s = | ||
| """ |
There was a problem hiding this comment.
The test data does not contains nulls by createTPCHNotNullTables(), so it cannot well test this feature.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
For aggregation followed by an inner join on the grouping keys, it's safe to mark the
ignoreNullKeysflag to true to avoid unnecessary aggregation on null keys.(Fixes: #8966)
How was this patch tested?
UT and manually