[GLUTEN-8956][VL] Add support for casting binary to string #8957
+57
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ArnavBalyan
force-pushed
the
arnavb/cast-varbin-string
branch
from
7659f0f to
e2f1275
Compare
| @@ -249,6 +249,9 @@ bool SubstraitToVeloxPlanValidator::isAllowedCast(const TypePtr& fromType, const | |||
| // 3. Timestamp to most categories except few supported types is not allowed. | |||
| // 4. Certain complex types are not allowed. | |||
|
|
|||
| auto fromKind = fromType->kind(); | |||
There was a problem hiding this comment.
fromKind is not used in anywhere.
| import org.apache.spark.sql.types._ | ||
|
|
||
| class VeloxCastSuite extends VeloxWholeStageTransformerSuite with ExpressionEvalHelper { | ||
| def cast(v: Any, targetType: DataType, timeZoneId: Option[String] = None): Cast = { |
There was a problem hiding this comment.
timeZoneId is not used. Maybe you can pass a const value to function 'Cast()'.
| def cast(v: Any, targetType: DataType, timeZoneId: Option[String] = None): Cast = { | ||
| v match { | ||
| case lit: Expression => | ||
| logDebug(s"Cast from: ${lit.dataType.typeName}, to: ${targetType.typeName}") |
There was a problem hiding this comment.
It is not better to add logs in a unit test.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
How was this patch tested?