Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[GLUTEN-8949][Core] Simplify synchronization from JniLibLoader #8950

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

[GLUTEN-8949][Core] Simplify synchronization from JniLibLoader #8950

wants to merge 1 commit into from
+34 −42

Conversation

ArnavBalyan
Copy link
Contributor

What changes were proposed in this pull request?

  • JniLibLoader some synchronizations which are no longer needed, these are benign but can be removed for improved performance.
  • Removed such synchronizations where we are already thread safe.

How was this patch tested?

  • Unit Tests

@github-actions github-actions bot added the CORE works for Gluten Core label Mar 10, 2025
@github-actions GitHub Actions
Copy link

#8949

@github-actions GitHub Actions
Copy link

Run Gluten ClickHouse CI on ARM

@zhztheplayer
Copy link
Member

As the APIs are mostly public static, I think the synchronisations are not completely meaningless. But there seems to be a problem that the synchronisations code is a little bit messy. Can we use a simple way to synchronize the code? E.g., by simply adding synchronzized keyword to all the public methods. Performance will not be an issue here, the APIs are expected only to be called a few times.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
CORE works for Gluten Core
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ArnavBalyan @zhztheplayer