[INFRA] Derive from Apache Software Foundation Parent POM #8930
Conversation
|
Thanks for opening a pull request! Could you open an issue for this pull request on Github Issues? https://github.com/apache/incubator-gluten/issues Then could you also rename commit message and pull request title in the following format? See also: |
|
Run Gluten ClickHouse CI on ARM |
1 similar comment
|
Run Gluten ClickHouse CI on ARM |
|
Run Gluten ClickHouse CI on ARM |
|
Run Gluten ClickHouse CI on ARM |
|
Run Gluten ClickHouse CI on ARM |
|
Run Gluten ClickHouse CI on ARM |
| @@ -154,7 +154,9 @@ | |||
| <plugin> | |||
| <groupId>org.apache.maven.plugins</groupId> | |||
| <artifactId>maven-surefire-plugin</artifactId> | |||
| <version>2.21.0</version> | |||
| <configuration> | |||
| <skipTests>false</skipTests> | |||
There was a problem hiding this comment.
@yaooqinn, could you explain why we need this?
There was a problem hiding this comment.
The behavior here is AS-IS. Since the ASF pom brings surefire-plugin and enables it globally by default, we disable it in our parent pom and restore it here.
There was a problem hiding this comment.
FYI, https://github.com/apache/incubator-gluten/actions/runs/13717946244/job/38366738976
One of the reasons why we need to disable the surefire-plugin is that one of our CI job failed w/ unknown parameters
| See the License for the specific language governing permissions and | ||
| limitations under the License. | ||
| --> | ||
| ~ Licensed to the Apache Software Foundation (ASF) under one or more |
There was a problem hiding this comment.
Could you help add the license in some other pom.xml?
There was a problem hiding this comment.
Let's do it separately to make the scope here clear
What changes were proposed in this pull request?
This PR adds pom parent Apache Software Foundation Parent POM
https://maven.apache.org/pom/asf/