[GLUTEN-8921][GLUTEN-8922][CH] Fix checkDecimalOverflowSparkOrNull and lead function

[lwz9103]

…d lead function

What changes were proposed in this pull request?

(Please fill in changes proposed in this fix)

(Fixes: #8921, #8922)

How was this patch tested?

(Please explain how this patch was tested. E.g. unit tests, integration tests, manual tests)

(If this patch involves UI changes, please attach a screenshot; otherwise, remove this)

[github-actions]

#8921

[github-actions]

Run Gluten Clickhouse CI on x86

[github-actions]

Run Gluten Clickhouse CI on x86

[baibaichen]

@CodiumAI-Agent /review

[baibaichen]

@CodiumAI-Agent /improve

[CodiumAI-Agent]

PR Code Suggestions ✨

Category	Suggestion	Impact
Possible issue	Add null pointer check Add a null pointer check for arg0_col before accessing its properties to avoid potential segmentation faults. cpp-ch/local-engine/Parser/aggregate_function_parser/LeadLagParser.cpp [79] const auto * arg0_col = parseExpression(actions_dag, arg0); +if (!arg0_col) { + throw std::runtime_error("Failed to parse expression for arg0."); +} Suggestion importance[1-10]: 5 __ Why: This suggestion enhances robustness by ensuring that a null pointer is caught before being dereferenced; while not essential if parseExpression is guaranteed non-null, the added safety check can prevent potential runtime errors.	Low
General	Remove duplicate tests Consolidate duplicate test cases or clearly differentiate their purposes to avoid redundancy. backends-clickhouse/src/test/scala/org/apache/gluten/execution/compatibility/GlutenClickhouseFunctionSuite.scala [445-459] -test("GLUTEN-8921: Type mismatch at checkDecimalOverflowSparkOrNull") { +test("GLUTEN-8921: Type mismatch - scenario 1") { compareResultsAgainstVanillaSpark( """ |select l_shipdate, avg(l_quantity), count(0) over() COU, |SUM(-1.1) over() SU, AVG(-2) over() AV, |max(-1.1) over() MA, min(-3) over() MI |from lineitem |where l_shipdate <= date'1998-09-02' |group by l_shipdate |order by l_shipdate """.stripMargin, true, { _ => } ) } +// Consider parameterizing similar tests into one. Suggestion importance[1-10]: 4 __ Why: The suggestion proposes renaming and consolidating similar test cases to reduce redundancy, which is a useful stylistic improvement but not critical to functionality.	Low

[github-actions]

Run Gluten Clickhouse CI on x86

[CodiumAI-Agent]

PR Code Suggestions ✨

No code suggestions found for the PR.

[taiyang-li]

LGTM

[github-actions]

Run Gluten Clickhouse CI on x86