[GLUTEN-8912][VL] Add Offset support for CollectLimitExec #8914
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Run Gluten Clickhouse CI on x86 |
| @@ -58,7 +58,7 @@ class GlutenSQLCollectLimitExecSuite extends WholeStageTransformerSuite { | |||
|
|
|||
| testWithSpecifiedSparkVersion( | |||
There was a problem hiding this comment.
testWithSpecifiedSparkVersion -> test
| @@ -67,7 +67,9 @@ class GlutenSQLCollectLimitExecSuite extends WholeStageTransformerSuite { | |||
| assertGlutenOperatorMatch[ColumnarCollectLimitBaseExec](df, checkMatch = true) | |||
| } | |||
|
|
|||
| testWithSpecifiedSparkVersion("ColumnarCollectLimitExec - with filter", Array("3.2", "3.3")) { | |||
| testWithSpecifiedSparkVersion( | |||
There was a problem hiding this comment.
ditto, so as others
| @@ -138,4 +140,34 @@ class GlutenSQLCollectLimitExecSuite extends WholeStageTransformerSuite { | |||
|
|
|||
| assertGlutenOperatorMatch[ColumnarCollectLimitBaseExec](unionDf, checkMatch = true) | |||
| } | |||
|
|
|||
| testWithSpecifiedSparkVersion("ColumnarCollectLimitExec - offset test", Array("3.4", "3.5")) { | |||
There was a problem hiding this comment.
What's the result for spark3.3? Is the result also correct but operator not matched?
There was a problem hiding this comment.
If that, please also add the result check for spark3.2 and spark3.3
There was a problem hiding this comment.
Please add the test to cover more code path, such as limit(12)
| partition => { | ||
| val droppedRows = dropLimitedRows(partition, offset) | ||
| val adjustedLimit = Math.max(0, limit - offset) | ||
| collectLimitedRows(droppedRows, adjustedLimit) |
There was a problem hiding this comment.
Can we enhance the collectLimitedRows, we can slice the input RowVector from offset to adjustedLimit?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
How was this patch tested?