[GLUTEN-3620][VL] RangeExec support for fallback by user options #8913
Conversation
|
Run Gluten Clickhouse CI on x86 |
ArnavBalyan
force-pushed
the
arnavb/range-configurable
branch
from
110cf00 to
c70618c
Compare
|
Run Gluten Clickhouse CI on x86 |
| @@ -1691,4 +1693,10 @@ object GlutenConfig { | |||
| .checkValue(_ > 0, s"must be positive.") | |||
| .createWithDefault(10) | |||
|
|
|||
| val COLUMNAR_RANGE_ENABLED = | |||
| buildConf("spark.gluten.sql.columnar.range") | |||
There was a problem hiding this comment.
what the difference between spark.gluten.sql.columnar.expand and here.
There was a problem hiding this comment.
spark.gluten.sql.columnar.expand belongs to the expand operator. spark.gluten.sql.columnar.range is meant for the newly added columnar range
| @@ -186,6 +186,7 @@ object Validators { | |||
| if !(glutenConf.enableColumnarSample && BackendsApiManager.getSettings | |||
| .supportSampleExec()) => | |||
| fail(p) | |||
| case p: ExpandExec if !glutenConf.enableColumnarRange => fail(p) | |||
There was a problem hiding this comment.
seems this same as gluten-substrait/src/main/scala/org/apache/gluten/extension/columnar/validator/Validators.scala#line 154
There was a problem hiding this comment.
you are trying to match ExpandExec again with glutenConf.enableColumnarRange, why
There was a problem hiding this comment.
Ah that's a good catch, it seems the ExpandExec got copied, updated it thanks!
ArnavBalyan
force-pushed
the
arnavb/range-configurable
branch
from
c70618c to
f9c55c6
Compare
|
Run Gluten Clickhouse CI on x86 |
What changes were proposed in this pull request?
How was this patch tested?