Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[VL] Enable map_concat function #8781

Merged
merged 1 commit into from
Mar 12, 2025
Merged

[VL] Enable map_concat function #8781

merged 1 commit into from
Mar 12, 2025

Conversation

rui-mo
Copy link
Contributor

@rui-mo rui-mo commented Feb 19, 2025

What changes were proposed in this pull request?

Enables map_concat function for both EXCEPTION and LAST_WIN deduplicate policies.

How was this patch tested?

Verified with UT.

@github-actions github-actions bot added CORE works for Gluten Core BUILD VELOX labels Feb 19, 2025
Copy link

Thanks for opening a pull request!

Could you open an issue for this pull request on Github Issues?

https://github.com/apache/incubator-gluten/issues

Then could you also rename commit message and pull request title in the following format?

[GLUTEN-${ISSUES_ID}][COMPONENT]feat/fix: ${detailed message}

See also:

Copy link

Run Gluten Clickhouse CI on x86

@FelixYBW
Copy link
Contributor

Which Velox PR it depends on?

@rui-mo
Copy link
Contributor Author

rui-mo commented Feb 20, 2025

Relies on facebookincubator/velox#12379.

Copy link

Run Gluten Clickhouse CI on x86

Copy link
Contributor

@jinchengchenghh jinchengchenghh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Update velox branch

Copy link

Run Gluten Clickhouse CI on x86

Copy link

Run Gluten Clickhouse CI on x86

@rui-mo rui-mo merged commit 30cbd88 into apache:main Mar 12, 2025
55 checks passed
@GlutenPerfBot
Copy link
Contributor

===== Performance report for TPCDS SF2000 with Velox backend, for reference only ====

query log/native_master_03_12_2025_time.csv log/native_master_03_11_2025_6ece721b1a_time.csv difference percentage
q1 11.07 10.33 -0.741 93.31%
q2 11.95 11.99 0.034 100.28%
q3 2.50 3.83 1.329 153.21%
q4 51.80 52.35 0.553 101.07%
q5 9.26 8.01 -1.243 86.57%
q6 3.90 6.70 2.794 171.56%
q7 3.81 3.76 -0.050 98.69%
q8 4.14 4.71 0.579 114.01%
q9 14.38 15.07 0.691 104.80%
q10 14.08 12.89 -1.192 91.54%
q11 28.16 28.41 0.253 100.90%
q12 2.21 2.71 0.504 122.83%
q13 5.50 5.85 0.348 106.32%
q14a 44.16 43.08 -1.087 97.54%
q14b 39.47 39.84 0.366 100.93%
q15 2.65 3.47 0.825 131.17%
q16 5.45 4.97 -0.480 91.19%
q17 5.95 7.45 1.504 125.28%
q18 7.73 8.48 0.750 109.70%
q19 4.39 4.39 0.002 100.04%
q20 2.46 2.94 0.475 119.29%
q21 1.25 1.21 -0.042 96.62%
q22 4.25 3.04 -1.203 71.66%
q23a 60.29 62.91 2.622 104.35%
q23b 72.45 72.13 -0.320 99.56%
q24a 71.37 68.34 -3.035 95.75%
q24b 70.10 63.82 -6.282 91.04%
q25 5.45 5.76 0.310 105.68%
q26 2.34 2.39 0.045 101.93%
q27 2.37 2.43 0.056 102.38%
q28 17.22 16.63 -0.590 96.57%
q29 7.56 7.77 0.209 102.77%
q30 5.71 6.64 0.936 116.40%
q31 8.12 7.97 -0.158 98.05%
q32 2.48 1.86 -0.618 75.03%
q33 3.67 3.63 -0.043 98.83%
q34 3.18 3.68 0.504 115.88%
q35 7.74 7.18 -0.566 92.69%
q36 2.47 2.40 -0.069 97.19%
q37 3.45 3.18 -0.271 92.14%
q38 11.81 12.15 0.339 102.87%
q39a 4.09 4.01 -0.078 98.09%
q39b 4.19 4.74 0.544 112.97%
q40 3.25 3.62 0.368 111.33%
q41 0.71 1.41 0.700 198.67%
q42 0.79 1.07 0.279 135.15%
q43 2.42 3.01 0.596 124.66%
q44 6.49 6.30 -0.194 97.01%
q45 3.52 3.78 0.262 107.44%
q46 5.23 4.53 -0.701 86.59%
q47 9.56 9.81 0.253 102.65%
q48 3.61 3.51 -0.099 97.25%
q49 5.16 5.65 0.484 109.37%
q50 17.62 17.90 0.284 101.61%
q51 8.11 8.13 0.025 100.31%
q52 0.83 0.70 -0.131 84.11%
q53 2.27 2.06 -0.210 90.75%
q54 5.75 6.51 0.762 113.26%
q55 0.61 1.07 0.458 174.72%
q56 4.27 3.80 -0.469 89.01%
q57 7.54 6.80 -0.737 90.22%
q58 3.31 2.68 -0.622 81.18%
q59 4.46 4.82 0.359 108.05%
q60 4.77 5.14 0.371 107.77%
q61 4.74 4.66 -0.081 98.30%
q62 2.71 2.92 0.206 107.61%
q63 1.68 2.51 0.835 149.77%
q64 37.01 36.34 -0.667 98.20%
q65 11.74 11.22 -0.513 95.63%
q66 2.83 2.94 0.110 103.89%
q67 57.97 57.92 -0.048 99.92%
q68 3.17 3.54 0.371 111.70%
q69 4.81 4.73 -0.075 98.44%
q70 5.36 6.31 0.957 117.86%
q71 4.77 4.82 0.049 101.02%
q72 20.37 21.05 0.674 103.31%
q73 2.51 2.76 0.248 109.84%
q74 17.69 17.85 0.159 100.90%
q75 22.25 23.55 1.294 105.81%
q76 7.31 6.87 -0.439 93.99%
q77 2.59 2.55 -0.039 98.51%
q78 33.23 32.38 -0.858 97.42%
q79 3.30 3.57 0.274 108.31%
q80 10.71 10.31 -0.399 96.28%
q81 6.51 7.00 0.492 107.57%
q82 5.66 5.35 -0.317 94.39%
q83 1.44 2.27 0.828 157.60%
q84 2.80 2.62 -0.177 93.67%
q85 5.75 5.77 0.021 100.37%
q86 1.99 2.35 0.367 118.48%
q87 11.72 12.25 0.531 104.53%
q88 15.90 15.81 -0.085 99.47%
q89 1.90 2.81 0.912 148.04%
q90 2.17 1.85 -0.318 85.34%
q91 3.66 3.93 0.264 107.22%
q92 1.67 1.86 0.187 111.19%
q93 24.15 25.21 1.061 104.39%
q94 8.76 9.14 0.380 104.33%
q9 54.70 58.23 3.530 106.45%
q5 1.87 2.56 0.691 137.02%
q96 10.77 10.38 -0.387 96.41%
q97 2.58 2.49 -0.088 96.59%
q98 5.14 5.29 0.153 102.98%
q99 0.62 0.53 -0.084 86.35%
total 1173.32 1183.88 10.558 100.90%

@GlutenPerfBot
Copy link
Contributor

===== Performance report for TPCH SF2000 with Velox backend, for reference only ====

query log/native_master_03_12_2025_time.csv log/native_master_03_11_2025_6ece721b1a_time.csv difference percentage
q1 25.49 24.99 -0.500 98.04%
q2 26.71 26.53 -0.175 99.34%
q3 32.81 33.26 0.443 101.35%
q4 28.33 27.58 -0.748 97.36%
q5 60.72 61.23 0.508 100.84%
q6 9.18 8.08 -1.099 88.03%
q7 41.37 38.93 -2.433 94.12%
q8 63.61 64.38 0.774 101.22%
q9 100.99 98.01 -2.983 97.05%
q10 43.03 42.59 -0.432 99.00%
q11 16.18 15.83 -0.344 97.87%
q12 15.55 17.42 1.874 112.06%
q13 24.57 24.36 -0.209 99.15%
q14 12.71 12.03 -0.686 94.60%
q15 26.71 25.68 -1.032 96.14%
q16 12.63 11.00 -1.638 87.04%
q17 74.55 73.52 -1.030 98.62%
q18 114.81 112.51 -2.300 98.00%
q19 24.11 17.68 -6.433 73.32%
q20 23.31 25.65 2.343 110.05%
q21 174.63 173.12 -1.519 99.13%
q22 10.84 13.17 2.333 121.53%
total 962.82 947.54 -15.286 98.41%

yikf pushed a commit to yikf/incubator-gluten that referenced this pull request Mar 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLICKHOUSE CORE works for Gluten Core VELOX
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants