Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[VL] Support casting varchar type to timestamp type #8357

Open
wants to merge 11 commits into
base: main
Choose a base branch
from
Open

[VL] Support casting varchar type to timestamp type #8357

wants to merge 11 commits into from
+941 −19

Conversation

PHILO-HE
Copy link
Contributor

@PHILO-HE PHILO-HE commented Dec 26, 2024 •
edited
Loading

What changes were proposed in this pull request?

Velox pr: facebookincubator/velox#11975

How was this patch tested?

Existing test.

@github-actions github-actions bot added the VELOX label Dec 26, 2024
@github-actions GitHub Actions
Copy link

Thanks for opening a pull request!

Could you open an issue for this pull request on Github Issues?

https://github.com/apache/incubator-gluten/issues

Then could you also rename commit message and pull request title in the following format?

[GLUTEN-${ISSUES_ID}][COMPONENT]feat/fix: ${detailed message}

See also:

@PHILO-HE PHILO-HE force-pushed the fix-timestamp-involved-cast-1 branch 4 times, most recently from 446e56a to 68dcb6b Compare December 31, 2024 07:52
@github-actions github-actions bot added the BUILD label Dec 31, 2024
@FelixYBW FelixYBW mentioned this pull request Jan 3, 2025
Open
@PHILO-HE PHILO-HE force-pushed the fix-timestamp-involved-cast-1 branch 2 times, most recently from 86afea2 to e6972de Compare January 13, 2025 02:09
@github-actions github-actions bot added the CORE works for Gluten Core label Jan 13, 2025
@github-actions GitHub Actions
Copy link

Run Gluten Clickhouse CI on x86

@DenineLu
Copy link

Looking forward to updates!

@PHILO-HE PHILO-HE force-pushed the fix-timestamp-involved-cast-1 branch from e6972de to ec14f8c Compare February 14, 2025 02:50
@github-actions GitHub Actions
Copy link

Run Gluten Clickhouse CI on x86

@PHILO-HE PHILO-HE force-pushed the fix-timestamp-involved-cast-1 branch from ec14f8c to dbad0c5 Compare February 14, 2025 05:43
@github-actions GitHub Actions
Copy link

Run Gluten Clickhouse CI on x86

1 similar comment
@github-actions GitHub Actions
Copy link

Run Gluten Clickhouse CI on x86

@PHILO-HE PHILO-HE force-pushed the fix-timestamp-involved-cast-1 branch from 14548e9 to 373e479 Compare February 17, 2025 02:38
@github-actions GitHub Actions
Copy link

Run Gluten Clickhouse CI on x86

1 similar comment
@github-actions GitHub Actions
Copy link

Run Gluten Clickhouse CI on x86

@PHILO-HE PHILO-HE force-pushed the fix-timestamp-involved-cast-1 branch from 5d95f14 to 5fa9a0c Compare February 18, 2025 02:45
@github-actions GitHub Actions
Copy link

Run Gluten Clickhouse CI on x86

@PHILO-HE PHILO-HE force-pushed the fix-timestamp-involved-cast-1 branch from 5fa9a0c to 30842bf Compare February 18, 2025 07:16
@github-actions GitHub Actions
Copy link

Run Gluten Clickhouse CI on x86

@PHILO-HE PHILO-HE force-pushed the fix-timestamp-involved-cast-1 branch from 30842bf to e2413bd Compare February 18, 2025 07:45
@github-actions GitHub Actions
Copy link

Run Gluten Clickhouse CI on x86

@PHILO-HE PHILO-HE force-pushed the fix-timestamp-involved-cast-1 branch from e2413bd to 85c5bd7 Compare February 18, 2025 09:57
@github-actions GitHub Actions
Copy link

Run Gluten Clickhouse CI on x86

1 similar comment
@github-actions GitHub Actions
Copy link

github-actions bot commented Mar 7, 2025

Run Gluten Clickhouse CI on x86

@PHILO-HE PHILO-HE force-pushed the fix-timestamp-involved-cast-1 branch from ae9be59 to 1d3c7ff Compare March 7, 2025 09:16
@PHILO-HE PHILO-HE marked this pull request as ready for review March 7, 2025 09:17
@github-actions github-actions bot removed the BUILD label Mar 7, 2025
@github-actions GitHub Actions
Copy link

github-actions bot commented Mar 7, 2025

Run Gluten Clickhouse CI on x86

2 similar comments
@github-actions GitHub Actions
Copy link

github-actions bot commented Mar 7, 2025

Run Gluten Clickhouse CI on x86

@github-actions GitHub Actions
Copy link

github-actions bot commented Mar 7, 2025

Run Gluten Clickhouse CI on x86

@PHILO-HE PHILO-HE force-pushed the fix-timestamp-involved-cast-1 branch from 0e6e64f to b04f07a Compare March 7, 2025 11:13
@github-actions GitHub Actions
Copy link

github-actions bot commented Mar 7, 2025

Run Gluten Clickhouse CI on x86

@PHILO-HE PHILO-HE force-pushed the fix-timestamp-involved-cast-1 branch from b04f07a to d2db96c Compare March 11, 2025 10:03
@github-actions GitHub Actions
Copy link

Run Gluten Clickhouse CI on x86

@github-actions GitHub Actions
Copy link

Run Gluten Clickhouse CI on x86

1 similar comment
@github-actions GitHub Actions
Copy link

Run Gluten Clickhouse CI on x86

@PHILO-HE PHILO-HE force-pushed the fix-timestamp-involved-cast-1 branch from 2256b78 to 147d9ec Compare March 12, 2025 16:20
@github-actions GitHub Actions
Copy link

Run Gluten Clickhouse CI on x86

@PHILO-HE
Copy link
Contributor Author

There are only few corner cases that got inconsistent result. The excluded test requiring further fix is tracked by #8984.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
CORE works for Gluten Core VELOX
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@PHILO-HE @DenineLu