[GLUTEN-8061][VL] Fall back nth_value if input is foldable #8062
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PHILO-HE
reviewed
Nov 27, 2024
| case _: RowNumber | _: Rank | _: CumeDist | _: DenseRank | _: PercentRank | | ||
| _: NthValue | _: NTile => | ||
| case _: RowNumber | _: Rank | _: CumeDist | _: DenseRank | _: PercentRank | _: NTile => | ||
| case nv: NthValue if !nv.input.foldable => |
There was a problem hiding this comment.
Just for brevity. Maybe, we can use:
case _ @NthValue(input, _, _) if !input.foldable =>
Ditto for Lead/Lag.
There was a problem hiding this comment.
This method is more friendly to changes in the number of parameters that may exist in multi-version support. Generally, we will not change the parameter names. What do you think?
There was a problem hiding this comment.
@zml1206, it makes sense. Thanks!
PHILO-HE
approved these changes
Nov 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Velox does not support nth_value when its input is foldable.
Although vanilla Spark supports foldable input of nth_value, there is almost no usage scenario in this case, and the values obtained are all null, so simply fall back for it.
(Fixes: #8061)
How was this patch tested?
UT