FINERACT-2176: fix Interest portion is missing from Charge-off transaction #4338
+137
−14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
magyari-adam
force-pushed
the
feature/FINERACT-2176
branch
from
b011a6f to
d9f7a41
Compare
adamsaghy
reviewed
Feb 24, 2025
| penaltychargesPortion = penaltychargesPortion | ||
| .plus(currentInstallment.getPenaltyChargesOutstanding(transactionCtx.getCurrency())); | ||
| } | ||
| principalPortion = principalPortion.plus(currentInstallment.getPrincipalOutstanding(transactionCtx.getCurrency())); |
There was a problem hiding this comment.
@magyari-adam I am not sure about this. If an installment is fully paid, there cannot be any outstanding, so removing this condition looks incorrect to me, no?
There was a problem hiding this comment.
In case of early repayment with zero interest after charge-off and interest reclaculation enabled, we (re)calculate the remaining interest portion on the installment where it would belong date wise, then blindly set the interest after the charge-off date to 0, and don't consider unrecognized interest there. In all other cases fully paid installments should have 0 outstanding so this shouldn't affect those.
magyari-adam
force-pushed
the
feature/FINERACT-2176
branch
from
d9f7a41 to
6410665
Compare
…ff when backdated full repayment happens on same period
tamasszabo-dpc
force-pushed
the
feature/FINERACT-2176
branch
from
5c87009 to
4f980b1
Compare
ruzeynalov
approved these changes
Feb 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Describe the changes made and why they were made.
Ignore if these details are present on the associated Apache Fineract JIRA ticket.
Checklist
Please make sure these boxes are checked before submitting your pull request - thanks!
Write the commit message as per https://github.com/apache/fineract/#pull-requests
Acknowledge that we will not review PRs that are not passing the build ("green") - it is your responsibility to get a proposed PR to pass the build, not primarily the project's maintainers.
Create/update unit or integration tests for verifying the changes made.
Follow coding conventions at https://cwiki.apache.org/confluence/display/FINERACT/Coding+Conventions.
Add required Swagger annotation and update API documentation at fineract-provider/src/main/resources/static/legacy-docs/apiLive.htm with details of any API changes
Submission is not a "code dump". (Large changes can be made "in repository" via a branch. Ask on the developer mailing list for guidance, if required.)
FYI our guidelines for code reviews are at https://cwiki.apache.org/confluence/display/FINERACT/Code+Review+Guide.