Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve RleDecoder performance #7195

Merged
merged 3 commits into from
Feb 27, 2025
Merged

Improve RleDecoder performance #7195

merged 3 commits into from
Feb 27, 2025

Conversation

Dandandan
Copy link
Contributor

@Dandandan Dandandan commented Feb 26, 2025 •
edited
Loading

Which issue does this PR close?

Closes #7206

Rationale for this change

Just some small performance improvement:

arrow_array_reader/Int64Array/dictionary encoded, mandatory, no NULLs
                        time:   [68.938 µs 70.463 µs 72.200 µs]
                        change: [-22.970% -21.331% -19.572%] (p = 0.00 < 0.05)
                        Performance has improved.
arrow_array_reader/Int64Array/dictionary encoded, optional, no NULLs
                        time:   [77.723 µs 79.461 µs 81.282 µs]
                        change: [-22.811% -20.776% -18.535%] (p = 0.00 < 0.05)
                        Performance has improved.

What changes are included in this PR?

Are there any user-facing changes?

@github-actions github-actions bot added the parquet Changes to the parquet crate label Feb 26, 2025
alamb
alamb approved these changes Feb 26, 2025
View reviewed changes
Copy link
Contributor

@alamb alamb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense to me -- thank you @Dandandan ❤️

etseidl
etseidl approved these changes Feb 26, 2025
View reviewed changes
Copy link
Contributor

@etseidl etseidl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice improvement 😄. Thanks!

@Dandandan Dandandan changed the title [Minor] Improve RleDecoder performance Improve RleDecoder performance Feb 27, 2025
@Dandandan Dandandan merged commit c1cb61d into apache:main Feb 27, 2025
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alamb alamb alamb approved these changes

@etseidl etseidl etseidl approved these changes

Assignees
No one assigned
Labels
parquet Changes to the parquet crate performance
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Improve Parquet RleDecoder performance
3 participants
@Dandandan @alamb @etseidl