feat(go/adbc/driver/flightsql): allow passing arbitrary grpc dial options in NewDatabase #2563
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ions in NewDatabase
Add a new database constructor NewDatabaseWithOptions to allow passing arbitrary user-specified grpc dial options.
This is useful for constructs like
```go
driver := flightsql.NewDriver(memory.DefaultAllocator)
driver.NewDatabaseWithOptions(map[string]string{
"uri": uri,
},
grpc.WithStatsHandler(otelgrpc.NewClientHandler())
)
```
which allows usage of the opentelemetry grpc instrumentation for example.
This also provides an escape valve for users that need the ability to use less commonly used grpc client features that we have not exposed via the string map args.
mariusvniekerk
commented
Feb 26, 2025
zeroshade
reviewed
Feb 26, 2025
zeroshade
reviewed
Feb 26, 2025
zeroshade
reviewed
Feb 27, 2025
zeroshade
reviewed
Feb 27, 2025
| @@ -76,13 +77,23 @@ type driverImpl struct { | |||
| driverbase.DriverImplBase | |||
| } | |||
|
|
|||
| type Driver interface { | |||
zeroshade
approved these changes
Feb 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a new database constructor NewDatabaseWithOptions to allow passing arbitrary user-specified grpc dial options.
This is useful for constructs like
which allows usage of the opentelemetry grpc instrumentation for example.
This also provides an escape valve for users that need the ability to use less commonly used grpc client features that we have not exposed via the string map args.