chore: update versions for 17-SNAPSHOT #2470
Conversation
lidavidm
requested review from
kou,
wjones127,
paleolimbot and
CurtHagenlocher
as code owners
| @@ -29,7 +29,7 @@ | |||
| <Product>Apache Arrow ADBC library</Product> | |||
| <Copyright>Copyright 2022-2024 The Apache Software Foundation</Copyright> | |||
There was a problem hiding this comment.
Should we update the copyright years as a separate change?
There was a problem hiding this comment.
Oops. Yes, let me follow up with another PR.
|
|
||
| ### Versions | ||
|
|
||
| - C/C++/GLib/Go/Python/Ruby: 1.4.0 |
There was a problem hiding this comment.
These are also the ADBC protocol version?
Could this be the reason loading a Go driver from Rust (dynamically) triggers version check errors?
Error: Error { message: "Unknown ADBC version: 1.4.0", status: InvalidArguments, vendor_code: 0, sqlstate: [0, 0, 0, 0, 0], details: None }
There was a problem hiding this comment.
That's interesting. The actual protocol version is separate, it's currently 1.1.0.
Something is sending 1.4.0 when it shouldn't be... or Rust is validating the wrong thing
There was a problem hiding this comment.
Hmm, the wrong string must've gotten changed somewhere...
There was a problem hiding this comment.
BTW, @felipecrv can you please open new issues instead of necroing older threads if possible?
There was a problem hiding this comment.
Also I think we need a backtrace. That appears to be from FromStr<AdbcVersion> so I think the Rust code appears to be parsing the driver version somewhere at a first glance. But it's hard to tell without any context.
There was a problem hiding this comment.
I figured what was the problem now! My environment had ADBC_SNOWFLAKE_ADBC_VERSION defined to 1.4.0. :/
BTW, @felipecrv can you please open new issues instead of necroing older threads if possible?
I wanted to confirm if there was an actual problem first and got here through git blame.
There was a problem hiding this comment.
We're happy to take questions over issues too!
No description provided.