Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(go/adbc/driver): driverbase implementation for connection #1590

Merged
merged 26 commits into from
Mar 19, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
26 commits
Select commit Hold shift + click to select a range
705bc1f
refactor(go/adbc/driver): connection and statement bases
joellubi Mar 1, 2024
03bc8b5
register missing driverinfo
joellubi Mar 4, 2024
2fa6c59
slices not available in go version
joellubi Mar 4, 2024
b4ae276
fix precommit
joellubi Mar 4, 2024
bbb63d2
fully implement interfaces in bases
joellubi Mar 4, 2024
569b059
refactor to match base semantics
joellubi Mar 5, 2024
3acb8a7
remove statement from pr
joellubi Mar 5, 2024
0088d1b
decompose helper interfaces
joellubi Mar 6, 2024
d853d11
implement getobjects via helper
joellubi Mar 7, 2024
2243be3
rewrite connection helpers using builder
joellubi Mar 7, 2024
f667031
flightsql to use conn bldr
joellubi Mar 8, 2024
f486016
revert snowflake stmt changes
joellubi Mar 8, 2024
e6dc8db
use bldr for snowflake and refactor autocommit
joellubi Mar 8, 2024
69a1771
implement additional snowflake conn helpers
joellubi Mar 8, 2024
5c3d21b
push autocommit state update into driverbase impl
joellubi Mar 8, 2024
cb70138
cleanup driverinfo handling
joellubi Mar 8, 2024
64f2d3a
cleanup comments
joellubi Mar 8, 2024
e05d8e4
more comment cleanup
joellubi Mar 8, 2024
7072fdf
handle close and additional info codes
joellubi Mar 8, 2024
1812bf5
cleanup interfaces
joellubi Mar 15, 2024
e4b8da1
pass logger to connection and add/refactor tests
joellubi Mar 15, 2024
acb2798
clean up comment
joellubi Mar 15, 2024
11f9bac
make driverbase internal
joellubi Mar 15, 2024
5daca0c
update currentnamespacer methods and implement for flightsql
joellubi Mar 15, 2024
8bc678f
clone string to avoid use after free
joellubi Mar 17, 2024
20915b1
rebase and mod tidy
joellubi Mar 17, 2024
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 11 additions & 0 deletions go/adbc/adbc.go
Original file line number Diff line number Diff line change
Expand Up @@ -355,6 +355,17 @@ const (
InfoDriverADBCVersion InfoCode = 103 // DriverADBCVersion
)

type InfoValueTypeCode = arrow.UnionTypeCode

const (
InfoValueStringType InfoValueTypeCode = 0
InfoValueBooleanType InfoValueTypeCode = 1
InfoValueInt64Type InfoValueTypeCode = 2
InfoValueInt32BitmaskType InfoValueTypeCode = 3
InfoValueStringListType InfoValueTypeCode = 4
InfoValueInt32ToInt32ListMapType InfoValueTypeCode = 5
)

type ObjectDepth int

const (
Expand Down
66 changes: 0 additions & 66 deletions go/adbc/driver/driverbase/driver.go

This file was deleted.

Loading
Loading