Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci: configure env vars for CI in .env file #1580

Merged
merged 1 commit into from
Mar 1, 2024
Merged

ci: configure env vars for CI in .env file #1580

merged 1 commit into from
Mar 1, 2024

Conversation

lidavidm
Copy link
Member

@lidavidm lidavidm commented Mar 1, 2024

Fixes #1545.

@github-actions github-actions bot added this to the ADBC Libraries 0.11.0 milestone Mar 1, 2024
@lidavidm lidavidm force-pushed the gh-1545 branch 4 times, most recently from b7eaae9 to 7dc8b65 Compare March 1, 2024 17:53
@lidavidm
Copy link
Member Author

lidavidm commented Mar 1, 2024 •
edited
Loading

TODOs

  • Java is skipping tests; need to figure out a better way to handle this
  • Flight SQL integration tests fail
  • PostgreSQL integration tests fail

@lidavidm lidavidm force-pushed the gh-1545 branch 2 times, most recently from 9244af4 to 2e7cfc3 Compare March 1, 2024 18:17
@lidavidm lidavidm marked this pull request as ready for review March 1, 2024 18:59
@lidavidm lidavidm requested a review from zeroshade as a code owner March 1, 2024 18:59
zeroshade
zeroshade approved these changes Mar 1, 2024
View reviewed changes
Copy link
Member

@zeroshade zeroshade left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@lidavidm lidavidm merged commit 56e96e2 into apache:main Mar 1, 2024
50 of 51 checks passed
@lidavidm lidavidm deleted the gh-1545 branch March 1, 2024 19:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zeroshade zeroshade zeroshade approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
ADBC Libraries 0.11.0
Development

Successfully merging this pull request may close these issues.

ci: create .env file to record the canonical URIs/other config for docker-based integration tests
2 participants
@lidavidm @zeroshade