feat(openid-connect): add jwt audience validator #11987
Open
+633
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dosubot
bot
added
size:XL
moonming
previously approved these changes
Feb 22, 2025
nic-chen
previously approved these changes
Feb 23, 2025
| }, | ||
| match_with_client_id = { | ||
| type = "boolean", | ||
| description = "audience must euqal to or includes client_id", |
There was a problem hiding this comment.
From the code, it can only be equals?
There was a problem hiding this comment.
Yes, if the match is true but not required, the correlation check with client_id is only performed if the aud value is not empty.
| return 403, core.json.encode(error_response) | ||
| end | ||
| elseif conf.client_id ~= audience_value then | ||
| core.log.error("OIDC introspection failed: ", |
There was a problem hiding this comment.
Compared to error, warn level seems more appropriate for these logs.
There was a problem hiding this comment.
Makes sense, but the rest of the code uses error, so I'm choosing to follow the precedent, should we break that "convention"?
We should consider the design of the configuration items more carefully, as it may not align with ergonomic best practices. I'd appreciate your feedback. From all the people who are concerned about this, not just the maintainers themselves. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add JWT audience authentication to the OpenID Connect plugin, which allows:
Fixes #11968 #11059
One of the developers in #11059 mentioned that it is possible to use some of the APIs in
jwt-validatorsto implement JWT validation inlua-resty-openidc, but it doesn't work, that library only works with local verification that uses a public key, and not with the Introspection API. We have to implement the functionality directly in the plugin code to support it in both scenarios.To keep compatibility, these features are not turned on by default and it is up to you to decide if you want to turn them on. Although the OIDC spec requires this to be the default behavior.
Checklist